Problem/Motivation

Right now the module load all medias with file type and then, all medias objects are pass to the batch so, this is wrong solution. Additional I can see warning in drupal log.

Deprecated function: Non-static method Drupal\media_pdf_thumbnail\Form\SettingsForm::regenerateThumbnails() should not be called statically w _batch_process()

Proposed resolution

You should load every single media entity with one batch step to work it correctly.

CommentFileSizeAuthor
#2 media_pdf_thumbnail-3085186-2.patch4.38 KBlamp5
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lamp5 created an issue. See original summary.

lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
CreditAttribution: lamp5 at abventor commented
Assigned: lamp5 » Unassigned
Status: Active » Needs review
FileSize
media_pdf_thumbnail-3085186-2.patch4.38 KB

Patch attached. Also fixed warning and applied drupal coding standards.

sgostanyan’s picture

sgostanyan CreditAttribution: sgostanyan as a volunteer and commented
Status: Needs review » Fixed

Thanks for the patch. Please update to version 2.1, several fix and code refactoring have been made.

sgostanyan’s picture

sgostanyan CreditAttribution: sgostanyan as a volunteer and commented
Status: Fixed » Closed (fixed)
lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
CreditAttribution: lamp5 at abventor commented

Please do not close issues which are fixed, these will be automatically closed after 2 weeks without activity. During these 2 weeks, we can check that everything working good.