Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
The Field Group module includes automated tests, but \Drupal\Tests\field_group\FunctionalJavascript\FieldGroupUiTest is currently failing. See https://www.drupal.org/node/948488/qa
Proposed resolution
Fix the failing \Drupal\Tests\field_group\FunctionalJavascript\FieldGroupUiTest
Remaining tasks
- Write a patch
- Review
- Commit
User interface changes
None.
API changes
None.
Data model changes
None.
Comment | File | Size | Author |
---|---|---|---|
#6 | 3072732-6.patch | 2.89 KB | idebr |
#6 | interdiff-4-6.txt | 618 bytes | idebr |
Comments
Comment #2
idebr CreditAttribution: idebr at ezCompany commentedFixed the inner working of \Drupal\Tests\field_group\FunctionalJavascript\FieldGroupUiTest::testCreateAndEdit(), but it seems the last test failure is legit.
Comment #4
idebr CreditAttribution: idebr at ezCompany commentedThe label element is being unset from format_settings since #2824350: missing UI for description text for field groups, so I removed these assertions from the test.
Comment #6
idebr CreditAttribution: idebr at ezCompany commentedLet's go with the smallest possible change and leave the duplicate label schema for a follow-up.
Comment #7
andypostLooks good except last removed line in test, where formatter extended
Comment #8
idebr CreditAttribution: idebr at ezCompany commented#7 Are you referring to these lines? The label property was removed in #2824350: missing UI for description text for field groups since its data was added twice in the configuration. This is what I referred to in #4:
field_group_group_save()
Comment #9
andypostYes, missed to check that. Let's unblock testing!
Comment #10
Chris Matthews CreditAttribution: Chris Matthews commented@maintainers, would it be possible to commit @idebr's patch in #6 so that we can, as @idebr stated in #2909960: Plan for Field Group 8.x-3.0, "go through the issue queue and help with issue triage and add test coverage where necessary."?
Comment #12
swentel CreditAttribution: swentel at eps & kaas for Dropsolid commentedCommitted and pushed, thanks!
Comment #13
swentel CreditAttribution: swentel at eps & kaas for Dropsolid commentedComment #14
idebr CreditAttribution: idebr at ezCompany commentedCheers! I filed a followup to enable strict config schema checking at #3085225: Enable strict config schema checking in \Drupal\Tests\field_group\Functional\ManageDisplayTest