Hi and thanks a lot for this wonderful module. We LOVE it!

We're just improving the admin form style and wondered why you chose a 'h4' for "Disabled items"?
This seems semantically incorrect because there is no 'h2' and 'h3' on regular node forms above.

In this first step I'm opening this discussion but haven't found a documentation abou the backend structure or a similar case for other node form elements yet. Do you have any orientation?

CommentFileSizeAuthor
#2 entity_reference_layout-heading_tag-3075099-2.patch1.55 KBjustin2pin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anybody created an issue. See original summary.

justin2pin’s picture

justin2pin CreditAttribution: justin2pin at Aten Design Group commented
Status: Active » Needs review
FileSize
entity_reference_layout-heading_tag-3075099-2.patch1.55 KB

Good question :).

I switched the container to a fieldset, and the custom H4 tag to the fieldset #title (legend tag). Patch attached.

justin2pin’s picture

justin2pin CreditAttribution: justin2pin at Aten Design Group commented
Status: Needs review » Fixed

And... pushed to dev, marked as fixed. @Anybody please reopen if you still have concerns about that markup.

  • justin2pin committed b7bb1ea on 8.x-1.x 
    Issue #3075099 by justin2pin: Admin UI: Why is "Disabled items" a <h4>?
justin2pin’s picture

justin2pin CreditAttribution: justin2pin at Aten Design Group commented
Status: Needs review » Fixed
Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented

Great, thank you very much! We'll have a look at the result soon when testing the latest dev. THANKS A LOT! :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.