Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Need to change Simple OAuth
from ~3.0
to ~4.0
Comment | File | Size | Author |
---|---|---|---|
#15 | issue-3079468.fix_simple_oauth_dependency_2.patch | 788 bytes | jedgar1mx |
#2 | issue-3079468.fix_simple_oauth_dependency.patch | 422 bytes | jedgar1mx |
Comments
Comment #2
jedgar1mx CreditAttribution: jedgar1mx commentedComment #3
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #6
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedCommitted ... Thank you Edgar :)
Comment #7
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #8
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #9
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #10
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #11
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedSimple OAuth Extras merged down into the main project
Comment #14
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedRemoved the simple_oauth:simple_oauth_extras from dependencies
I find out that they do not have a hook update to switch off simple_oauth_extras and migrate configs start with simple_oauth_extras to simple_oauth
More testing on updates
Comment #15
jedgar1mx CreditAttribution: jedgar1mx commentedI removed the dependency from the info.yml but still saying that simple_oath_extras is required.🤔
Comment #16
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedThanks for helping and testing with me
I think you will need to do a
then
composer update
Working well with a new install on the dev branch of varbase
I think we need optimize an update function to work in varbase_api or in the simple_oauth module
Testing updates with the following in the .install file
Still having issues on update with the code, it's not taking the affect I want yet.
I do think that this hook should be in the simple_oauth
Comment #17
jedgar1mx CreditAttribution: jedgar1mx commentedIt seems like the maintainers are not providing an upgrade path see issue #3078547
Comment #18
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedNoted;
Thank you Edgar, we will have it upgrade in Varbase, then we report back to them
#3078547: Merge Simple OAuth Extras in Simple OAuth
Having the varbase_api_update_8701 hook from #16 with more testing
In Varbase we had #3051884: Switch to use [Varbase Entity Definition Update Manager] and remove deprecated \Drupal::entityDefinitionUpdateManager()->applyUpdates()
Comment #19
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedSeems that Simple Oauth 8.x-4.1 is out
Comment #20
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedSimple OAuth 8.x-4.2 is out
Comment #22
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedUpdated the varbase_api_update_8701 hook update to be able to update and not to keep showing the notice
and
Comment #23
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #24
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #25
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedFollow up #3085671: Fix the update process to uninstall the Simple Oauth Extras module as it was merged into Simple Oauth to make it work without conditions
Comment #26
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedWe could suggest the update hook to the maintainers for Simple OAuth
I think they had no free time to bring the hook out, or they may have more info if their are more to do to have the complete hook update.
as we did in
#3085671: Fix the update process to uninstall the Simple Oauth Extras module as it was merged into Simple Oauth to make it work without conditions
Comment #27
jedgar1mx CreditAttribution: jedgar1mx commentedIt does look like they are too busy to implement it, but you can always reach out 😄