Message text in admin/content/message is empty if the text contains html.

Patch forthcoming which should more clearly highlight the issue.

CommentFileSizeAuthor
#8 message-text-in-admin-page-empty-if-html-3048631-#8.patch1.66 KBmalte.koelle
#8 message-text-in-admin-page-empty-if-html-3048631-#8-interdiff.txt937 bytesmalte.koelle
#5 3048631-fix-get-text-no-display.patch1.28 KBmacganibo
#4 3048631-fix-get-text-no-display.patch684 bytesmacganibo
#3 Screen Shot 2019-09-09 at 6.51.05 PM.png29.44 KBmacganibo
#2 3048631-feat-message-Not-properly-displaying-getText-w-html.patch1.08 KBsylus
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sylus created an issue. See original summary.

sylus’s picture

sylus CreditAttribution: sylus commented
FileSize
3048631-feat-message-Not-properly-displaying-getText-w-html.patch1.08 KB
macganibo’s picture

macganibo CreditAttribution: macganibo commented
FileSize
Screen Shot 2019-09-09 at 6.51.05 PM.png29.44 KB

I have the same issue when creating messages, the ui renders an empty row. Also, when fetching the message entity programmatically $message->getText(); does not map tokens properly.

macganibo’s picture

macganibo CreditAttribution: macganibo commented
FileSize
3048631-fix-get-text-no-display.patch684 bytes

Added a patch for #3

macganibo’s picture

macganibo CreditAttribution: macganibo commented
FileSize
3048631-fix-get-text-no-display.patch1.28 KB
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Active » Needs review

That's great, thanks for working through it!

Please try to remember to set the issue status to "Needs review" when you upload a patch, that will trigger the testbot to test the file and indicates to others that there's something to review.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 commented
Status: Needs review » Needs work
Issue tags: +Needs tests

The approaches in #2 and #5 are quite different. Not sure what the token changes are in #5, but we definitely need to pass the message entity in.

malte.koelle’s picture

malte.koelle CreditAttribution: malte.koelle at Unic commented
Status: Needs work » Needs review
FileSize
message-text-in-admin-page-empty-if-html-3048631-#8-interdiff.txt937 bytes
message-text-in-admin-page-empty-if-html-3048631-#8.patch1.66 KB

Patch #2 works fine for me. I created a test to cover the specific scenario.

  • jhedstrom committed 046e80a on 8.x-1.x authored by malte.koelle 
    Issue #3048631 by macganibo, malte.koelle, sylus: Message text in admin/...
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 commented
Status: Needs review » Fixed

Thanks for the test @malte.koelle!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.