Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
This is a follow up of Make paragraphs module working with field_group version 3.x with support for the field_layout module
. In that issue we added support for field_group 3.x but due a bug in field_group we couldn't add the test for it yet.
Proposed resolution
Once #3064890 is fixed we can update the tests to use field_group 3.x.
let's see
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 3073177-9.patch | 1.79 KB | swentel |
| #5 | 3073177-5.patch | 416 bytes | swentel |
| #11 | 3073177-11.patch | 1.79 KB | swentel |
| |||
| #2 | 3073177_2.patch | 1.77 KB | mpp |
Comments
Comment #2
mpp CreditAttribution: mpp as a volunteer and at AmeXio for District09 commentedAdded a patch to update the tests to field_group 3.x. These should fail as #3064890 needs to be solved first.
Comment #4
BerdirComment #5
swentel CreditAttribution: swentel at eps & kaas for Dropsolid commentedComment #6
swentel CreditAttribution: swentel at eps & kaas for Dropsolid commentedI think the tests will pass if the test uses standard drupalPostform. The issues with those notices are because of drag and drop which acts annoying sometimes (fixed at least one issue which was related to DS too though)
Comment #8
swentel CreditAttribution: swentel at eps & kaas for Dropsolid commentedWow interesting, will have a look.
Comment #9
swentel CreditAttribution: swentel at eps & kaas for Dropsolid commentedHmm right, the tests were wrong in that sense that it didn't set the region of the field group. This fixes them.
However, one can argue whether the field group shouldn't be in the default region (usually 'content', unless ds is also enabled) anyway when creating. This is something which wasn't a problem in Drupal before the region key was introduced (which is part of core Field UI now, nothing todo with Field Layout).
Given that, it's not a bad idea to set that region anyway in the test. I've opened #3086050: Set default region when creating a field group to set a default region in Field Group though too.
Comment #11
swentel CreditAttribution: swentel at eps & kaas for Dropsolid commentedUgh, names ...
Comment #13
BerdirThanks! Wasn't the expectation of my tweet that you work on it yourself but glad for the help :)
Comment #14
swentel CreditAttribution: swentel at eps & kaas for Dropsolid commentedNo problem at all :) I was on a roll anyway and I'm glad this one is sorted out. It gives us at least the comfort to say that things are mostly stable, at least on the API side of the modules, now trying to fix the front-end part - that might be a /little/ more tricky :)
Comment #15
mpp CreditAttribution: mpp as a volunteer and at AmeXio for District09 commentedAwesome, thanks!