Problem/Motivation

Follow-up of #2982684: Add a composer scaffolding plugin to core.

The example in composer/Plugin/Scaffold/README.md contains minor bugs.

Proposed resolution

1. Change drupal/composer-scaffold to drupal/core-composer-scaffold.

 {
   "name": "my/project",
   "require": {
-    "drupal/composer-scaffold": "*",
+    "drupal/core-composer-scaffold": "*",
     "composer/installers": "^1.2",
     "cweagans/composer-patches": "^1.6.5",

2. Delete trailing comma, because this is not valid JSON.

   "extra": {
     "composer-scaffold": {
       "allowed-packages": [
-        "drupal/core",
+        "drupal/core"
       ],

Remaining tasks

Add credits for greg.1.anderson and mohit_aghera. They added notes to the documentation Using Drupal's Composer Scaffold. See the discussions.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Krzysztof Domański created an issue. See original summary.

Krzysztof Domański’s picture

Status: Active » Needs review
FileSize
821 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 3086118-2.patch, failed testing. View results

Krzysztof Domański’s picture

Status: Needs work » Needs review

Unrelated test failure 3031379#comment-13287788.

greg.1.anderson’s picture

Status: Needs review » Reviewed & tested by the community

Looks good - thanks.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 0671ed8 and pushed to 8.8.x. Thanks!

  • alexpott committed 0671ed8 on 8.8.x
    Issue #3086118 by Krzysztof Domański: Correct the example in composer/...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.