Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
It seems that #3082694: Extra space between message and content when content has elements with margin-top didn't help everywhere I thought.
Proposed resolution
See before / after.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#17 | interdiff.txt | 331 bytes | lauriii |
#12 | claro-better_messages_spacing-3086510-12--fixed-10.patch | 6.68 KB | huzooka |
| |||
#10 | interdiff.txt | 3.27 KB | lauriii |
#10 | claro-better_messages_spacing-3086510-10.patch | 6.68 KB | lauriii |
| |||
#8 | interdiff.txt | 5.9 KB | lauriii |
Comments
Comment #1
huzookahuzooka created an issue. See original summary.
Comment #2
huzookaComment #3
ckrinaLGTM! Both on a design and code review perspective.
Comment #4
lauriiiCould we add documentation on why this is needed?
Should we create a new inline variation of the message-list? We probably can't do that easily now so I'd be happy to move that to a follow-up.
Comment #5
lauriiiCan we also update this to the design system?
Comment #6
saschaeggiUpdated the specs in the design system: https://www.figma.com/file/OqWgzAluHtsOd5uwm1lubFeH/Drupal-Design-system...
Comment #7
lauriiiThanks for updating this to the design system!
#4 still needs to be addressed.
Comment #8
lauriiiAddressed #4.1. I think we should move #4.2 to future since it doesn't seem like there's a reliable way to determine when messages should be rendered inline. Maybe it's something we can work in a follow-up.
Comment #9
fhaeberleThis looks good! Tested it and setting the tag.
Comment #10
lauriiiI realized that the Drupal message library doesn't have dependency on jQuery. I removed it from here as well.
Comment #11
huzookaThe patch in #10 adds an extra trailing space to the end of the
js/messages.es6.js
.Apart from the error above, this looks (more than) good for me :)
Do we really need the follow-up? (I assume that we don't need it.)
Comment #12
huzookaComment #13
lauriiiWe should work on that when we find use cases for it. I don't think we need a follow-up.
Comment #14
huzookaComment #17
lauriiiAwesome! I had to run eslint --fix to make this comply with our coding standards. Interdiff attached.
Committed and pushed 🚀
Comment #18
lauriiiUpdated issue credits.