Capitalize the name of the module, because module names are proper nouns.
Also according to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!

CommentFileSizeAuthor
#2 dwr-info-3077514-2.patch380 bytesalonaoneill
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

Assigned: alonaoneill » Unassigned
Status: Active » Needs review
FileSize
380 bytes
jcnventura’s picture

Status: Needs review » Reviewed & tested by the community

Seems fine by me.

  • alonaoneill authored 3ac48f8 on 8.x-1.x
    Issue #3077514 by alonaoneill, jcnventura: Capitalize the name of the...
jcnventura’s picture

Status: Reviewed & tested by the community » Fixed

I'll release a new v1.3 branch that will be based on 1.1, including the patches in 1.2. As such, the dependency namespacing is a duplicate of
https://git.drupalcode.org/project/dwr/commit/64a3a17f0e6faed40025cdf29e...

I'll change the module name.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.