Allow alter base url for sitemap [#2951689]

In the code for the hook url alter options we can't override base url. I think we need to add an extra condition to check if we are overriding the base url in the hook.

For example with a multisite with multiple domains. I created a context per domain and then I need to say a domain per context but I can't override because always use the same. I attach a patch for fix this problem.

Comment	File	Size	Author
	allow_alter_base_url.patch	774 bytes	fastangel
	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.6 54 pass, 4 fail PHP 7.1 & MySQL 5.7, D8.7 Patch Failed to Apply PHP 7.1 & MySQL 5.7, D8.8 Patch Failed to Apply

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

9 March 2018 at 21:35

fastangel created an issue. See original summary.

Comment #2

pifagor

🇺🇦 Rivne

CreditAttribution: pifagor as a volunteer and at GOLEMS GABB for GOLEMS GABB commented 11 March 2018 at 22:01

You have to enable patch testing

Comment #3

pifagor

🇺🇦 Rivne

CreditAttribution: pifagor at GOLEMS GABB for GOLEMS GABB commented 11 March 2018 at 22:43

This patch didn't passed the tests. you need to work on the patch

Comment #4

pawel_r CreditAttribution: pawel_r commented 26 March 2018 at 19:32

I had problem after moving from test to production server: base_url was always as test it was on test server. There is no good solution (at the moment) besides changing state value: \Drupal::state()->set('xmlsitemap_base_url','PRODUCTION BASE URL');

Waiting for proper patch.