CommentFileSizeAuthor
#12 3086198-12.patch20.22 KBXiaohua Guan
#6 3086198-6.patch19.33 KBXiaohua Guan
#4 screenshot-20191010a.png1.01 MByas
#4 3086198-4.patch13.5 KByas
#2 3086198-2.patch17.75 KBXiaohua Guan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
FileSize
3086198-2.patch17.75 KB
Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
Status: Active » Needs review

@yas

Please review the patch file. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
FileSize
3086198-4.patch13.5 KB
screenshot-20191010a.png1.01 MB

@xiaohua-guan

Thank you for adding the graph. It looks good to me.

screenshot-20191010a.png

I fixed the coding standard violations but could you please add the comments? (Please see below --- I left the empty comments)

FILE: /var/www/html/web/modules/contrib/cloud/modules/tools/s3_to_k8s/s3_to_k8s.module
--------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------
 72 | ERROR | Doc comment is empty
--------------------------------------------------------------------------------------

FILE: /var/www/html/web/modules/contrib/cloud/modules/cloud_service_providers/k8s/k8s.module
--------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------
 627 | ERROR | Doc comment is empty
--------------------------------------------------------------------------------------------
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Related issues: +#3084313: Composer could not parse version constraint / could not load package
Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
FileSize
3086198-6.patch19.33 KB
Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented

@yas

I added comments. Please review the new patch file. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented

@xiaohua-guan

Thank you for the update. Now it looks good to me.

@baldwinlouie
@masami

Could you please review the patch?

baldwinlouie’s picture

baldwinlouie CreditAttribution: baldwinlouie commented

@all, this looks good to me.

baldwinlouie’s picture

baldwinlouie CreditAttribution: baldwinlouie commented
Status: Needs review » Reviewed & tested by the community
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented

@baldwinlouie

Thank you for your review. I'll merge the patch to 8.x-2.x and close this issue as Fixed.

Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
FileSize
3086198-12.patch20.22 KB

  • yas committed 917da9a on 8.x-2.x authored by Xiaohua Guan 
    Issue #3086198 by Xiaohua Guan, yas, baldwinlouie: Monitor each pod by a...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

@xiaohua-guan

Thank you for the update. I've just merged the patch to 8.x-2.x and closed this issue as Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.