Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.It seems to me that when the services module is enabled, js_server_info will conflict hook_server_info. That is services_get_servers in services.module will call js_server_info, but it doesn't appear that js_server_info provides services in the format expected by services (see services.services.api.php). This causes the "server" dropdown to have a malformed value in it when adding/editing endpoints as well as throwing the following php notice: "Notice: Undefined index: name in services_ctools_export_ui_form() (line 100 of sites/all/modules/contrib/services/plugins/export_ui/services_ctools_export_ui.inc)."
If js_server_info is intended to implement hook_server_info, it should provide data in the expected format. If not, it should be renamed to not conflict.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 3075281-7.patch | 990 bytes | markhalliwell |
Comments
Comment #2
mthomas CreditAttribution: mthomas commentedComment #3
mthomas CreditAttribution: mthomas commentedComment #4
mthomas CreditAttribution: mthomas commentedPatch with possible fix.
Comment #5
markhalliwellI'm half tempted to say that this should be fixed in the services module.
This is a very broad and generic "hook" for them to be using. It should have been prefixed with "services" IMO.
It's already excluding one module from hook_server_info:
https://git.drupalcode.org/project/services/blob/7.x-3.x/services.module...
---
That being said, it should be possible to remove the JS module from their hook using hook_module_implements_alter.
Comment #6
markhalliwellComment #7
markhalliwell