Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan’s picture

Xiaohua Guan’s picture

Status: Active » Needs review

@yas

Please review the patch file. Thanks.

yas’s picture

FileSize
893.05 KB

@xiaohua-guan

Thank you for adding the pricing fieldset. I tested it and looks good. I would like to ask you to add/change as follows:

  1. Change the fieldset name from Price to Costs
  2. Add an Instance Type field in the Costs (Price) fieldset although it is already shown in beta.kubernetes.io/instance-type.
  3. Can we align the height between the lines in the Costs (Price) fieldset as the same as Metrics? Should it be addressed by CSS?

Please see also the screenshot as shown in below:
screenshot-20191016a.png

By the way, I like the following code:

@@ -102,4 +161,56 @@ class K8sNodeViewBuilder extends CloudViewBuilder {

+    if (empty($instance_type)
+    || empty($region)
+    || !$this->moduleHandler->moduleExists('aws_cloud')) {
+      unset($build['price']);
+      return;
Xiaohua Guan’s picture

Xiaohua Guan’s picture

@yas

Please review the patch file. Thanks.

yas’s picture

Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for the update. I tested it and it is exactly what I requested for you. I'll merge the patch to 8.x-2.x and close this issue as Fixed.

  • yas committed f074114 on 8.x-2.x authored by Xiaohua Guan
    Issue #3088188 by Xiaohua Guan, yas: Check the instance type cost in EKS...
yas’s picture

Status: Reviewed & tested by the community » Fixed
yas’s picture

Issue summary: View changes
FileSize
915.07 KB
yas’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.