Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JeroenT created an issue. See original summary.

JeroenT’s picture

Patch attached fixes the local tasks for Drupal 8.8 and makes sure it still works for older Drupal versions.

JeroenT’s picture

Status: Active » Needs review
JeroenT’s picture

Title: Local tasks are no longer present on drupal 8.8.x » Local tasks are no longer present on Drupal 8.8.x
Berdir’s picture

Thanks I guess it makes sense to keep this separate from #3012050: Prepare for the conversion of path aliases to entities. Any chance you have time to add some basic test coverage for this? I might get to it in the next days if not.

JeroenT’s picture

JeroenT’s picture

JeroenT’s picture

Hmm. It won't work using LocalTaskIntegrationTestBase because it won't pick up the changes made in pathauto_local_tasks_alter

Berdir’s picture

Yeah, that's IMHO too low-level and not that useful to test for core regressions.

I'd just expand our existing test at \Drupal\Tests\pathauto\FunctionalJavascript\PathautoUiTest::testPatternsWorkflow. In setUp(), place the locla task and local actions block, like \Drupal\Tests\views_ui\Functional\ViewsListTest::setUp.

And then in that test method, instead of going directly to patterns/add, go to the path page, assert the local tasks that we add, click on patterns, then click on the action. That should be enough and easy to make it work on D7 and D8.

Berdir’s picture

  • Berdir committed 1ab8967 on 8.x-1.x authored by JeroenT
    Issue #3088811 by JeroenT, Berdir: Local tasks are no longer present on...
Berdir’s picture

Status: Needs review » Fixed

Now it fails/passes as expected, thanks for the patch!

pyxio’s picture

i am having this same issue with drupal 8.7.8. using the already patched pathauto 8.x-1.x-dev

Symfony\Component\Routing\Exception\RouteNotFoundException: Route "entity.path_alias.collection" does not exist. in Drupal\Core\Routing\RouteProvider->getRouteByName() (line 201 of /var/ww

the site is fine until i login and then this error and white screen of death. clearing caches do not bring the site back once i have attempted a login and received this error. i am really stuck now because i cannot login to make config changes. strangely, the site appears fine for anybody until an attempted login and then white screen and it can't be brought back.

can you please help? thank you

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

chema_’s picture

I am having same issue than Pyxio but in 8.8.5
Any idea?

thanks