See https://www.drupal.org/node/3013865

The webform module queries the removed url_alias table in two places:

\Drupal\Tests\webform\Kernel\Entity\WebformEntityTest::testPaths, test-only code, probably just wrap in a table/entity type exists check as suggested by the change record (both for installling the entity type on 8.8 and querying it).

In webform_update_8153(). This was added ~ 1y ago and most users are hopefully on more recent versions now but in case someone isn't, that update is going to fail. I only discovered this because we have update path tests in our install profile that installs a now pretty old dump and runs all updates. I update the dump from time to time but haven't done it in a while so now it is tests a pretty big gap. What seems to work is defining update dependencies in case someone is updating from a version that is that old. However, in reverse webform_update_8139() fails if executed *before* system_update_8804().

So something like this:

    'system' => [
      8804 => ['webform' => 8153],
    ],
    'webform' => [
      8139 => ['system' => 8804],
    ],

I'll try to provide a patch asap, just wanted to document what I found so far.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir created an issue. See original summary.

Berdir’s picture

I think the definition isn't correct yet, but I need to run now, will update later :)

Berdir’s picture

That happens when you're in a hurry, obviously the update dependencies approach won't work, math is hard sometimes ;)

And the test was already updated in the dev version.

Berdir’s picture

Title: Incompatibility with Drupal 8.8 » Update webform_update_8153() to also work on Drupal 8.8
Status: Active » Needs review
FileSize
2.54 KB

Then lets try a different approach, this should work on both core versions. Not tested yet.

Berdir’s picture

As I said, untested.. now with 100% less syntax errors.

Berdir’s picture

And one more fix, the field name is now path, not source.

jrockowitz’s picture

@Berdir I am about to tag a new stable release. The patch from #6 seems fine with me. Are you okay with me committing it?

Berdir’s picture

I think so. I don't think my test run actually had any path aliases to delete, but at least the query did run through and it passed my update tests now.

  • Berdir authored efc2517 on 8.x-5.x
    Issue #3089018 by Berdir: Update webform_update_8153() to also work on...
jrockowitz’s picture

Status: Needs review » Fixed

@Berdir Thanks for the patch

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.