See https://www.drupal.org/node/3013865
The webform module queries the removed url_alias table in two places:
\Drupal\Tests\webform\Kernel\Entity\WebformEntityTest::testPaths, test-only code, probably just wrap in a table/entity type exists check as suggested by the change record (both for installling the entity type on 8.8 and querying it).
In webform_update_8153(). This was added ~ 1y ago and most users are hopefully on more recent versions now but in case someone isn't, that update is going to fail. I only discovered this because we have update path tests in our install profile that installs a now pretty old dump and runs all updates. I update the dump from time to time but haven't done it in a while so now it is tests a pretty big gap. What seems to work is defining update dependencies in case someone is updating from a version that is that old. However, in reverse webform_update_8139() fails if executed *before* system_update_8804().
So something like this:
'system' => [
8804 => ['webform' => 8153],
],
'webform' => [
8139 => ['system' => 8804],
],
I'll try to provide a patch asap, just wanted to document what I found so far.
Comment | File | Size | Author |
---|---|---|---|
#6 | webform-8-8-update-3089018-4.patch | 2.53 KB | Berdir |
| |||
#5 | webform-8-8-update-3089018-3.patch | 2.53 KB | Berdir |
| |||
#4 | webform-8-8-update-3089018.patch | 2.54 KB | Berdir |
Comments
Comment #2
BerdirI think the definition isn't correct yet, but I need to run now, will update later :)
Comment #3
BerdirThat happens when you're in a hurry, obviously the update dependencies approach won't work, math is hard sometimes ;)
And the test was already updated in the dev version.
Comment #4
BerdirThen lets try a different approach, this should work on both core versions. Not tested yet.
Comment #5
BerdirAs I said, untested.. now with 100% less syntax errors.
Comment #6
BerdirAnd one more fix, the field name is now path, not source.
Comment #7
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented@Berdir I am about to tag a new stable release. The patch from #6 seems fine with me. Are you okay with me committing it?
Comment #8
BerdirI think so. I don't think my test run actually had any path aliases to delete, but at least the query did run through and it passed my update tests now.
Comment #10
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented@Berdir Thanks for the patch