php drupal-check.phar modules/contrib/high_contrast/
 9/9 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ---------------------------------------------------- 
  Line   src/Form/HighContrastConfigurationForm.php          
 ------ ---------------------------------------------------- 
  195    Call to deprecated function file_unmanaged_copy().  
 ------ ---------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 1 error
CommentFileSizeAuthor
#3 deprecated-3087000-3.patch2.91 KBNeograph734
#2 deprecated-3087000-2.patch2.15 KBSergiu Stici
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sergiu Stici created an issue. See original summary.

Sergiu Stici’s picture

Sergiu Stici CreditAttribution: Sergiu Stici at FFW commented
Status: Active » Needs review
FileSize
deprecated-3087000-2.patch2.15 KB

Here is the patch, please review.

Neograph734’s picture

Neograph734
he/him
Location Netherlands
CreditAttribution: Neograph734 as a volunteer commented
FileSize
deprecated-3087000-3.patch2.91 KB

Thanks for the effort. In file_unmanaged_copy() the second parameter could be omitted, but this is no longer the case with fileSystem->copy(). I had to alter the patch a bit, please find it attached.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at Drupal Ukraine Community, GOLEMS GABB for Drupal Ukraine Community, GOLEMS GABB commented
Status: Needs review » Reviewed & tested by the community

  • pifagor committed 8591eb9 on 8.x-1.x authored by Neograph734 
    Issue #3087000 by Sergiu Stici, pifagor, Neograph734: Deprecated Code...
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at Drupal Ukraine Community, GOLEMS GABB for Drupal Ukraine Community, GOLEMS GABB commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.