Test that immediate login works if enabled, remove our code that forces the login

If you could do that, that would be great.

I am also looking for a really simple login process.

I am a Drupal newbie so if you could provide any information as to where and how to patch that would be awesome.

Does this patch provide the existing, built-in functionality for logging users in immediately after registration at admin/user/settings ?

... "With it unchecked, users will be logged in immediately upon registering, and may select their own passwords during registration."

Patch worked. Thank you!

I looked through the code in user.module for a little while and I'm not sure why we should have to do this in email_registration.module instead of just letting user.module "do the right thing." But, I'm very new to email_registration module so perhaps it is my lack of knowledge.

@heydemo - could you explain this a bit more? I agree that we should be respecting that core setting.

I can confirm that without this patch email_registration will not work as it should with "Require e-mail verification when a visitor creates an account" unticked.

Committed to 6.x.1.x-dev

Sorry to open up an old issue, but I think we may be missing an important step here.

It is as simple as setting the global user object to the account parameter of hook_user.

Don't we also need to call either user_external_login or user_authenticate_finalize? Otherwise the auto-login function in this module will not properly invoke the login functionality happening in other modules.

For example, I'm having a conflict with Secure Pages Hijack Prevention module. SPHP contains the following code:

/**
 * Implementation of hook_user().
 */
function securepages_prevent_hijack_user($op, &$edit, &$user, $category = NULL) {
  switch ($op) {
  case 'login':
    _securepages_prevent_hijack_cookie();
    break;

  case 'after_update':
    // Regenerate our cookie after password changes.
    if (!empty($edit['pass'])) {
      _securepages_prevent_hijack_cookie();
    }
    break;
  }
}

The login hook is not getting invoked by Email Registration module upon auto-login, as it should.

In my particular use case I'm creating a new user by calling user_save in my custom module, so I'm not using the usual user/register form.

Yep, makes sense to me. Does this also affect 7.x?

Yes, it appears it does so let's fix it there first and then backport.

user_external_login is for modules that authenticate against another system, so I think that user_authenticate_finalize is the right function to use here.

user_authenticate_finalize is user_login_finalize in D7.

Attached is a patch to add it to d7 and add some tests to be more confident that it works.

I actually don't see why this code is needed at all. I removed it all and left in the new tests and it all still works.

Removing this code should help with issues like #738134: Conflict with LoginToboggan submit handler.

Now committed to 7.x-1.x http://drupalcode.org/project/email_registration.git/commit/1c1c453

Here's a re-roll for D6.

Tests pass - committed to 6.x-1.x as well http://drupalcode.org/project/email_registration.git/commit/168a8d2