"Present on the article detail page, below the header we can see title and breadcrumb with a gradient background. So the plan should add some article header styles in theme options. if User selected a global style that will be applied to all article detail page.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sreenivas Bttv created an issue. See original summary.

Sreenivas Bttv’s picture

Assigned: Unassigned » Sreenivas Bttv
Sreenivas Bttv’s picture

Please review the patch article_header_style_change-3084566.patch
The patch has a new option added in theme settings in the Page Options tab. Choose page header style as per needs.

Sreenivas Bttv’s picture

Status: Active » Needs review
pratik_kamble’s picture

Status: Needs review » Needs work

@sreenivas-bttv theme_get_setting() is deprecated. Please check link FYR: https://www.drupal.org/node/3035289

Sreenivas Bttv’s picture

@pratik_kamble, given link https://www.drupal.org/node/3035289 in draft status and as core issue mentioned in that change of record https://www.drupal.org/project/drupal/issues/3035288 shows as postponed due to different dependencies. Please check for more details on the mentioned issue.

Also as latest Drupal 8.7.8 theme_get_setting() works fine. It may be required to use \Drupal::service('theme_handler') in an upcoming release of Drupal 9.x that too if method available.
(https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Extension...)

Sreenivas Bttv’s picture

Assigned: Sreenivas Bttv » Unassigned
Status: Needs work » Needs review
sd9121’s picture

Assigned: Unassigned » sd9121
sd9121’s picture

Assigned: sd9121 » Unassigned
Status: Needs review » Needs work

Hi @Sreenivas Bttv, #3 patch failing. Can you please resolve merge conflict and again release the patch.

Sreenivas Bttv’s picture

Status: Needs work » Needs review
FileSize
387.64 KB

@sd9121, The conflicts because of the last patch commit for the issue https://www.drupal.org/project/electra/issues/3084577.
I have fixed please review my new patch Article-Header-style-3084566-2.patch

Sreenivas Bttv’s picture

#10 failing because of trailing white space error.
So attached another patch. Please review -> Article-Header-style-3084566-3.patch

sd9121’s picture

Assigned: Unassigned » sd9121
sd9121’s picture

@Sreenivas Bttv LGTM

sd9121’s picture

Assigned: sd9121 » Unassigned
Status: Needs review » Fixed

  • Sreenivas Bttv committed 6f2cc54 on 8.x-1.x
    Issue #3084566 by Sreenivas Bttv, sd9121: Article Header style change...
Sreenivas Bttv’s picture

Status: Fixed » Closed (fixed)

@sd9121, Thanks for reviewing
Committed and pushed to 8.x-1.x branch.