Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
"Present on the article detail page, below the header we can see title and breadcrumb with a gradient background. So the plan should add some article header styles in theme options. if User selected a global style that will be applied to all article detail page.
Comment | File | Size | Author |
---|---|---|---|
#11 | Article-Header-style-3084566-3.patch | 13.59 KB | Sreenivas Bttv |
#10 | Article-Header-style-3084566-2.patch | 387.64 KB | Sreenivas Bttv |
#3 | header_boxsize_node_full_view.gif | 3.12 MB | Sreenivas Bttv |
#3 | header_fullsize_node_full_view.gif | 6.9 MB | Sreenivas Bttv |
#3 | header_default_node_full_view.gif | 3.3 MB | Sreenivas Bttv |
Comments
Comment #2
Sreenivas Bttv CreditAttribution: Sreenivas Bttv at QED42 commentedComment #3
Sreenivas Bttv CreditAttribution: Sreenivas Bttv at QED42 commentedPlease review the patch article_header_style_change-3084566.patch
The patch has a new option added in theme settings in the Page Options tab. Choose page header style as per needs.
Comment #4
Sreenivas Bttv CreditAttribution: Sreenivas Bttv at QED42 commentedComment #5
pratik_kamble@sreenivas-bttv theme_get_setting() is deprecated. Please check link FYR: https://www.drupal.org/node/3035289
Comment #6
Sreenivas Bttv CreditAttribution: Sreenivas Bttv at QED42 commented@pratik_kamble, given link https://www.drupal.org/node/3035289 in draft status and as core issue mentioned in that change of record https://www.drupal.org/project/drupal/issues/3035288 shows as postponed due to different dependencies. Please check for more details on the mentioned issue.
Also as latest Drupal 8.7.8 theme_get_setting() works fine. It may be required to use \Drupal::service('theme_handler') in an upcoming release of Drupal 9.x that too if method available.
(https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Extension...)
Comment #7
Sreenivas Bttv CreditAttribution: Sreenivas Bttv at QED42 commentedComment #8
sd9121 CreditAttribution: sd9121 at QED42 commentedComment #9
sd9121 CreditAttribution: sd9121 at QED42 commentedHi @Sreenivas Bttv, #3 patch failing. Can you please resolve merge conflict and again release the patch.
Comment #10
Sreenivas Bttv CreditAttribution: Sreenivas Bttv at QED42 commented@sd9121, The conflicts because of the last patch commit for the issue https://www.drupal.org/project/electra/issues/3084577.
I have fixed please review my new patch Article-Header-style-3084566-2.patch
Comment #11
Sreenivas Bttv CreditAttribution: Sreenivas Bttv at QED42 commented#10 failing because of trailing white space error.
So attached another patch. Please review -> Article-Header-style-3084566-3.patch
Comment #12
sd9121 CreditAttribution: sd9121 at QED42 commentedComment #13
sd9121 CreditAttribution: sd9121 at QED42 commented@Sreenivas Bttv LGTM
Comment #14
sd9121 CreditAttribution: sd9121 at QED42 commentedComment #16
Sreenivas Bttv CreditAttribution: Sreenivas Bttv at QED42 commented@sd9121, Thanks for reviewing
Committed and pushed to 8.x-1.x branch.