Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
I'm encountering a configuration error when trying to switch from included PB to excluded PB.
The required validation is running before the the paragraph bundles are added. (see screenshot).
Comment | File | Size | Author |
---|---|---|---|
#11 | entity_reference_layout-config_error-3045458-12.patch | 1.26 KB | justin2pin |
#10 | interdiff.txt | 1.06 KB | BramDriesen |
#10 | 3045458-11.patch | 1.94 KB | BramDriesen |
#4 | screenshot 2019-04-22 22.00.29.png | 34.31 KB | s-jack |
exclude config exception.gif | 4.66 MB | Tom Robert |
Comments
Comment #2
itamair CreditAttribution: itamair as a volunteer commentedI tried to reproduce your issues (on the last dev) but I couldn't ...
May you update with the last dev and verify it still happens to you, to confirm might be a general issue, and not just yours one.
This is working nice for me ...
Comment #3
itamair CreditAttribution: itamair as a volunteer commentedComment #4
s-jack CreditAttribution: s-jack commentedAfter installing the 8.x-1.0-alpha1, I created a new content type for testing and created an Entity Reference with Layout field type.
Even if I select some paragraph types, the Layout paragraph type is not displayed at all.
Comment #5
JLeMosy CreditAttribution: JLeMosy commentedI get the same error message with 8.x-1.0-alpha2 when trying to re-use an existing ERL field on an additional content type.
Comment #6
7thkey CreditAttribution: 7thkey as a volunteer commentedI have the same problem when adding an existing ERL field into another type of node.
Comment #7
BramDriesenBump
Comment #8
BramDriesenThe gif might be outdated, but the issue is still present when you try to save the form. The negate option seems to break with the AJAX callback.
Comment #9
BramDriesenThe issue seems to be that when AJAX is processing the form, the $this->getSettings() goes to the database instead of looking at the form_state values. Not sure if this patch is any good though... it seems to fix the issue.
Setting to needs review so others can test.
Comment #10
BramDriesenFixed a small mistake
Comment #11
justin2pin CreditAttribution: justin2pin at Aten Design Group commentedThanks @BramDriesen!
I don't think we need to check $form_state if a value is set since the FAPI should do that already. I think the problem happens when we set the default value to an option that no longer exists, when going from "Include.." to "Exclude..".
I uploaded a somewhat simpler patch (with some ugly "ifs" though) that doesn't call form_state directly again. Let me know what you think!
Comment #12
BramDriesenI'll test this on Monday and let you know how it goes :-) thanks for your response!
Comment #13
BramDriesenSorry for the delay. Your patch also fixed the issue.
Agreed the ifs are a bit ugly, but can be cleaned up in a later stage I guess.
RTBC!!
Comment #14
justin2pin CreditAttribution: justin2pin at Aten Design Group commentedLooks like this has been fixed in dev for a while but I never flagged the issue as fixed. Doing that now, thanks.