Please remove unused variable in metatag.module:

FILE: ...0/site1101/web/vendor/drupal/pareviewsh/pareview_temp/metatag.module
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 411 | WARNING | Unused variable $key.
--------------------------------------------------------------------------
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ilchovuchkov created an issue. See original summary.

vuil’s picture

Issue summary: View changes
vuil’s picture

Title: Update metatag.module file - remove unused variables and other similar issues » Update metatag.module file - remove unused variable
Issue summary: View changes
vuil’s picture

vuil’s picture

Status: Active » Needs review
vuil’s picture

Title: Update metatag.module file - remove unused variable » Remove unused variable in metatag.module
Issue summary: View changes
DamienMcKenna’s picture

Title: Remove unused variable in metatag.module » Coding standards improvements (D8)
Status: Needs review » Needs work

Thank you for taking the time to do this. Please combine changes from #3072167: Remove unused variable in src/MetatagDefaultsListBuilder.php, and any other coding standards improvements you can spot.

vuil’s picture

Status: Needs work » Active
vuil’s picture

Status: Active » Needs review
vuil’s picture

Status: Needs review » Reviewed & tested by the community
DamienMcKenna’s picture

Status: Reviewed & tested by the community » Needs review

FYI you shouldn't mark your own patches as RTBC.

Did you check the rest of the codebase to see if there were other changes to be made?

DamienMcKenna’s picture

I ran coder on the codebase, it found a bunch more.

  • DamienMcKenna committed 1a70b67 on 8.x-1.x
    Issue #3072165 by vuil, DamienMcKenna: Coding standards improvements.
    
DamienMcKenna’s picture

Status: Needs review » Fixed

Committed. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

vuil’s picture