Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Please remove unused variable in metatag.module
:
FILE: ...0/site1101/web/vendor/drupal/pareviewsh/pareview_temp/metatag.module
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
411 | WARNING | Unused variable $key.
--------------------------------------------------------------------------
Comment | File | Size | Author |
---|---|---|---|
#13 | metatag-n3072165-13.interdiff.txt | 7.35 KB | DamienMcKenna |
#13 | metatag-n3072165-13.patch | 8.54 KB | DamienMcKenna |
| |||
#9 | 3072165-9.patch | 1.23 KB | vuil |
Comments
Comment #2
vuilComment #3
vuilComment #4
vuilComment #5
vuilComment #6
vuilComment #7
DamienMcKennaThank you for taking the time to do this. Please combine changes from #3072167: Remove unused variable in src/MetatagDefaultsListBuilder.php, and any other coding standards improvements you can spot.
Comment #8
vuilComment #9
vuilMerge the patch of #3072167: Remove unused variable in src/MetatagDefaultsListBuilder.php
Thank you.
Comment #10
vuilComment #11
vuilComment #12
DamienMcKennaFYI you shouldn't mark your own patches as RTBC.
Did you check the rest of the codebase to see if there were other changes to be made?
Comment #13
DamienMcKennaI ran coder on the codebase, it found a bunch more.
Comment #15
DamienMcKennaCommitted. Thanks.
Comment #17
vuil