Only local images are allowed.

CommentFileSizeAuthor
#7 screenshot-20191023a.png272.86 KByas
#5 3089560-5-2_x.patch5.39 KBXiaohua Guan
#4 3089560-4-1_x.patch5.34 KBXiaohua Guan
#3 3089560-3-1_x.patch5.34 KBXiaohua Guan
#2 3089560-2.patch5.4 KBXiaohua Guan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
FileSize
3089560-2.patch5.4 KB
Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
FileSize
3089560-3-1_x.patch5.34 KB
Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
FileSize
3089560-4-1_x.patch5.34 KB
Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
FileSize
3089560-5-2_x.patch5.39 KB

@yas

Please review the patch file. Thanks.

FYI, after some research, I think it will be better to add a new configuration item to module aws_cloud setting than to add a new one to the setting of cloud provider. The reason is that, even though the endpoint is dependent on region, we can provide json files as the structure below just like aws pricing endpoint.

ENDPOINT
  - region1
    - index.json
  - region2
    - index.json
Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
FileSize
screenshot-20191023a.png272.86 KB

@xiaohua-guan

Thank you for your review. I tested it and looks good to me. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.

  • yas committed a8af9a1 on 8.x-1.x authored by Xiaohua Guan 
    Issue #3089560 by Xiaohua Guan, yas: Make the $ec2PricingEndpoint...

  • yas committed e5ca674 on 8.x-2.x authored by Xiaohua Guan 
    Issue #3089560 by Xiaohua Guan, yas: Make the $ec2PricingEndpoint...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Related issues: +#3084313: Composer could not parse version constraint / could not load package

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.