As the theme is based on Bootstrap 4, for all form elements need to adjust colors, font sizes, spacing, etc...
As noticed for a few elements like fieldset, select, checkboxes need to provide theme variations. Also theming adjusted to third party popular modules/libraries Field Group, Chosen, Select2.

CommentFileSizeAuthor
#3 form_elements_themeing-3084572.patch16.02 KBSreenivas Bttv
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sreenivas Bttv created an issue. See original summary.

Sreenivas Bttv’s picture

Sreenivas Bttv CreditAttribution: Sreenivas Bttv at QED42 commented
Assigned: Unassigned » Sreenivas Bttv
Sreenivas Bttv’s picture

Sreenivas Bttv CreditAttribution: Sreenivas Bttv at QED42 commented
Assigned: Sreenivas Bttv » Unassigned
Status: Active » Needs review
FileSize
form_elements_themeing-3084572.patch16.02 KB

Please review patch form_elements_themeing-3084572.patch

Before review please run the gulp command to generate CSS file.

pratik_kamble’s picture

pratik_kamble
Location Pune, India
CreditAttribution: pratik_kamble at QED42 commented

@sreenivas-bttv Patch LGTM.

  • Sreenivas Bttv committed 3f644fa on 8.x-1.x 
    Issue #3084572 by Sreenivas Bttv, pratik_kamble: Form elements default...
Sreenivas Bttv’s picture

Sreenivas Bttv CreditAttribution: Sreenivas Bttv at QED42 commented
Status: Needs review » Fixed

@pratik_kamble,
Thanks for reviewing the patch #3.
Patch committed and pushed to 8.x-1.x branch.

Sreenivas Bttv’s picture

Sreenivas Bttv CreditAttribution: Sreenivas Bttv at QED42 commented
Status: Fixed » Closed (fixed)