PHP Fatal error: Declaration of Drupal\\workbench_moderation\\Plugin\\Menu\\EditTab::getTitle() must be compatible with Drupal\\Core\\Menu\\LocalTaskDefault::getTitle(?Symfony\\Component\\HttpFoundation\\Request $request = NULL) in /code/web/modules/contrib/workbench_moderation/src/Plugin/Menu/EditTab.php on line 16, referer: http://localhost/admin/content

Using PHP 7.2 & Drupal core 8.5.0.

CommentFileSizeAuthor
#24 incompatible-gettitle-2952717-24.patch77.97 KBsam-elayyoub
#5 workbench_moderation_incompatible-declaration_2952717_4.patch1.14 KBsyammohanmp
#2 workbench_moderation_incompatible-declaration_2952717_2.patch1000 bytespingers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pingers created an issue. See original summary.

pingers’s picture

pingers CreditAttribution: pingers as a volunteer and at University of Adelaide commented
FileSize
workbench_moderation_incompatible-declaration_2952717_2.patch1000 bytes

Here's a patch.

syammohanmp’s picture

syammohanmp CreditAttribution: syammohanmp at Zyxware Technologies commented
Status: Active » Reviewed & tested by the community

It's working fine.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: workbench_moderation_incompatible-declaration_2952717_2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

syammohanmp’s picture

syammohanmp CreditAttribution: syammohanmp at Zyxware Technologies commented
FileSize
workbench_moderation_incompatible-declaration_2952717_4.patch1.14 KB

Here's the updated patch.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
CreditAttribution: darvanen commented
Related issues: +#2942578: Content Moderation module marked as stable produces failures in Workbench Moderation assets loading, +#2954109: Make WorkbenchModerationTestTrait PSR4 compliant

Commits will have to wait until #2942578: Content Moderation module marked as stable produces failures in Workbench Moderation assets loading is cleared and then #2954109: Make WorkbenchModerationTestTrait PSR4 compliant as they're blocking tests.

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde at BriarMoon Design for North Studio commented
Status: Needs work » Reviewed & tested by the community

As soon as those two land, this is functional and will resolve some issues.

Peter Majmesku’s picture

Peter Majmesku
Location 🇩🇪Düsseldorf
CreditAttribution: Peter Majmesku as a volunteer commented

Please add this patch to a stable release.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
CreditAttribution: darvanen commented

Submitted for re-testing.

Peter Majmesku’s picture

Peter Majmesku
Location 🇩🇪Düsseldorf
CreditAttribution: Peter Majmesku as a volunteer commented

Just as a hint: I was seeing this error on my entire Drupal site, when I was switching from PHP 7.1 to PHP 7.2. After switching back to PHP 7.1, the error was gone.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
CreditAttribution: darvanen commented

It might be difficult to get maintainer support for this until the tests are passing and that's a whole 'nother problem right now with this module.

armyguyinfl’s picture

armyguyinfl CreditAttribution: armyguyinfl as a volunteer and commented

I also confirm this bug on PHP 7.2 with 8.5.3. PHP 7.1 works as a temporary solution until this is merged into core.

Lanoxx’s picture

Lanoxx CreditAttribution: Lanoxx as a volunteer commented

I also had to change `core/lib/Drupal/Core/Menu/LocalTaskInterface.php` and add the Request parameter there.

hassebasse’s picture

hassebasse CreditAttribution: hassebasse commented

When upgrading to PHP7.2 I had this problem. As I can't downgrade to 7.1 I tried the patch workbench_moderation_incompatible-declaration_2952717_4.patch on Drupal 8.6.3 and installed it with Composer. It seem to work perfectly well.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
CreditAttribution: darvanen commented

Looks like module tests are passing again, re-queueing for testing.

mcdeltat’s picture

mcdeltat CreditAttribution: mcdeltat commented

Can confirm that the patch in #5 helped fixed this issue on a PHP7.2 Drupal 8.6.3 Workbench 1.4 installation. Thanks to #14 for also pointing out that you can do that directly in composer with the cweagans/composer-patches plugin. That is a much nicer way of deploying.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
CreditAttribution: darvanen commented

Looks like I was wrong, branch is still failing.
BTW - if you haven't tried content moderation in core as an alternative to workbench, now is a good time, it's looking nice :)

vinlaurens’s picture

vinlaurens CreditAttribution: vinlaurens at Ordina Digital Services for Ordina Digital Services commented

Can confirm the method above works for my Drupal 8.6.3 installation with workbench_moderation 1.4.

pritam.tiwari’s picture

pritam.tiwari CreditAttribution: pritam.tiwari as a volunteer commented

Patch #5 working for me with PHP 7.2 and Drupal 8.6.7

chandu7929’s picture

chandu7929 CreditAttribution: chandu7929 commented

Patch #5 working fine with Drupal (8.6.7) and workbench_moderation (1.4.0) on PHP7.2

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

Fixed, thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

sam-elayyoub’s picture

sam-elayyoub CreditAttribution: sam-elayyoub as a volunteer commented
FileSize
incompatible-gettitle-2952717-24.patch77.97 KB

Here's patch to fix all bugs included this bug, with drupal code standards

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Closed (fixed) » Fixed
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Fixed » Closed (fixed)
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Closed (fixed) » Fixed
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Fixed » Closed (fixed)
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented