Problem/Motivation

Follow up to #2347783-150: Deprecate drupal_get_path() and drupal_get_filename() and replace with ExtensionList::getPath() and ExtensionList::getPathname() we do not have a property for $themeInitialization in \Drupal\Core\Theme\Registry even though we set it in the constructor.

Proposed resolution

Add the property like:

/**
  * The theme initialization.
  *
  * @var \Drupal\Core\Theme\ThemeInitializationInterface
  */
protected $themeInitialization;

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

CommentFileSizeAuthor
#2 3086397-addvar-2.patch517 bytessubson
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kim.pepper created an issue. See original summary.

subson’s picture

subson CreditAttribution: subson as a volunteer commented
Status: Active » Needs review
FileSize
3086397-addvar-2.patch517 bytes

Added the property.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
CreditAttribution: kim.pepper at PreviousNext commented
Status: Needs review » Reviewed & tested by the community

LGTM!

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Technically this is a BC break because AMT the property is public and this makes it protected. Therefore going to commit this to 8.9.x and 9.0.x and not 8.8.x to given anyone who is using public access the chance to just get the service themselves.

Committed and pushed ebb2ac232f to 9.0.x and cbe491b440 to 8.9.x. Thanks!

  • alexpott committed ebb2ac2 on 9.0.x 
    Issue #3086397 by subson, kim.pepper: Registry does not declare a...

  • alexpott committed cbe491b on 8.9.x 
    Issue #3086397 by subson, kim.pepper: Registry does not declare a...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.