Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
The currently existing functionality implements "Did you mean". The views plugin to select for it is named "Spellcheck".
Proposed resolution
I suggest to consistently rename the existing functionality to "Did you mean" throughout the project files.
Remaining tasks
- After that we should a second Views plugin that offers a "Spellcheck" in way that offers multiple suggestions to user instead a single "Did you mean" suggestion.
- Update the documentation and add this link to this project's homepage on d.o.
Comment | File | Size | Author |
---|---|---|---|
#8 | interdiff-5-8.txt | 1.22 KB | tim-diels |
#8 | 3054367-8.patch | 12.16 KB | tim-diels |
#3 | Schermafbeelding 2019-05-29 om 16.36.13.png | 79.74 KB | tim-diels |
Comments
Comment #2
mkalkbrennerComment #3
tim-dielsFound some time to work on this issue and with some suggestions of @mkalkbrenner I came up with the patch attached.
Comment #4
borisson_I only found some nitpicks but haven't tested this manually at all.
I think the 80 cols rule also goes for readme files. So we should probably rewrap this under 80 cols wide.
This should be protected instead of private, so that others extending this class can easily change this.
/s/you/your/
Comment #5
tim-dielsSolved the remarks.
Comment #6
borisson_This looks good, I have not manually tested this and am not confident enough about the codebase to rtbc without testing, but the patch gets a +1.
Comment #7
mpp CreditAttribution: mpp at AmeXio for District09 commented@tim-diels, would you care to add this to the documentation once this gets in?
== => ===
Comment #8
tim-diels@mpp I'm sure willing to add that to the documentation once it gets committed.
I changed the 2 == to ===
Comment #9
borisson_RTBC based on the feedback by @mpp and my own review earlier.
Comment #10
mpp CreditAttribution: mpp at AmeXio for District09 commentedGreat!
Comment #11
dksdev01 CreditAttribution: dksdev01 commentedAny update on 8.x release branch?
Comment #13
mkalkbrenner