For a variety of reasons, known and unknown, in order to upgrade between major versions of drupal (and potentially minor versions), for users that are starting with 8.8.x or 8.9.x, and using the drupal/recommended-project template
, they must upgrade *both* the drupal/core-recommended
*and* the drupal/dev-dependencies
, and for consistencies sake, should probably
also update core-vendor-hardening and drupal/core-composer-scaffold.
The following command is something that will work, but is somewhat unwieldy:
composer require drupal/core-recommended:^9 drupal/dev-dependencies:^9 drupal/core-vendor-hardening drupal/core-composer-scaffold --update-with-dependencies
The ideal command would be:
composer require drupal/core* --update-with-dependences
In order to do this, we should rename both drupal/dev-dependencies and drupal/pinned-dev-dependencies to start with core
(drupal/core-dev
and drupal/core-dev-pinned
) dropping the term "dependencies" to keep the packagenames manageable and eliminate redundancy.
Comment | File | Size | Author |
---|---|---|---|
#20 | 3090684_20.patch | 9.33 KB | Mixologic |
#18 | interdiff_8_16.txt | 2.53 KB | Mixologic |
#18 | 3090684_16.patch | 9.23 KB | Mixologic |
#8 | 3090684-8_9.0.x.patch | 7.97 KB | greg.1.anderson |
#8 | 2-to-8-interdiff.txt | 3.56 KB | greg.1.anderson |
Comments
Comment #2
MixologicComment #3
MixologicComment #4
opdaviesI was speaking with Ryan about this earlier today, and I'd like to get more involved with the Composer initiative.
Reviewing and RTBC-ing this patch seems like a good first step. :)
One thing to note reading the issue description, the
--with-all-dependencies
option is not present, at least for me running Composer 1.9.0 (though it's the current stable release). I assume Ryan means the--update-with-all-dependencies
option.Comment #5
greg.1.anderson CreditAttribution: greg.1.anderson at Pantheon commentedThe issue summary says we are going to rename to
drupal/core-dev-pinned
, but the patch usesdrupal/core-pinned-dev
.I think that the version in the issue summary is better. If you had a script that wanted to update the dependencies, but wasn't sure if the target used pinned or non-pinned dependencies, it could use
drupal/core-dev*
. I minor point, but*
-on-the-end is clearer.Comment #6
opdaviesAttached is a new patch, and an interdiff compared to #2, using
drupal/core-dev*
.Comment #7
greg.1.anderson CreditAttribution: greg.1.anderson at Pantheon commentedThanks for the updated patch, @opdavies. Looks good to me. A patch for Drupal 9 would be useful as well.
Comment #8
greg.1.anderson CreditAttribution: greg.1.anderson at Pantheon commentedHere's a patch for 9.0.x, with interdiff.
Comment #9
Mixologictitle fix
Comment #10
greg.1.anderson CreditAttribution: greg.1.anderson at Pantheon commented@mixologic and I agree this is ready for core committer review.
Comment #11
greg.1.anderson CreditAttribution: greg.1.anderson at Pantheon commentedJust noticed I accidentally ran the 9.0.x patch against 8.9.x. Queuing up another test.
Comment #12
jibranHow would this work for existing projects using these packages already?
Comment #13
greg.1.anderson CreditAttribution: greg.1.anderson at Pantheon commentedDrupal 8.8.0 is alpha; we do not guarantee compatibility. Existing projects will simply need to rename these packages in their root-level composer.json. We can provide a change record for early adopters.
Comment #14
greg.1.anderson CreditAttribution: greg.1.anderson at Pantheon commentedSpeaking of which, this must go in 8.8.x, or not be committed at all. It wouldn't be good to have differently-named packages for the different versions of Drupal. The 8.9.x patch applies to 8.8.x.
We'll also have to rename the legacy package names (for Drupal 8.7.x and earlier).
Comment #15
alexpottin composer/Generator/Builder/DrupalCoreRecommendedBuilder.php needs an update (I think)
These comments need re-flowing so we make the best use of the 80 chars
Re-flow...
Comment #16
jibranIt is fine for 8.8.x but I'm concerned about 8.7.x and before.
Comment #17
greg.1.anderson CreditAttribution: greg.1.anderson at Pantheon commentedThe 8.7.x components provided for use with the Drupal 8.8.x scaffold tool are also alpha. Folks will just have to rename one package.
Comment #18
Mixologic2, 3, 4 all addressed.
This patch applies cleanly to 8.8/8.9/9.0.x
Comment #19
alexpottNeeds re-flowing :)
Comment #20
MixologicComment #21
MixologicWe concur solidly that all text is now reflowed.
Comment #22
alexpottCommitted and pushed 7d71991c2d to 9.0.x and 54c8aae944 to 8.9.x and 7d073337c6 to 8.8.x. Thanks!
Backported to 8.8.x after discussing with @catch
Comment #27
ressa CreditAttribution: ressa at Ardea commentedAdding related issue.