I have scanned the gin theme with the upgrade status module. One warning was found, which I have attached as a screenshot.

CommentFileSizeAuthor
#2 drupal-9-compability-3090734-2.patch314 bytesmalte.koelle
Screenshot 2019-10-29 at 11.26.13.png75.65 KBmalte.koelle
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

malte.koelle created an issue. See original summary.

malte.koelle’s picture

malte.koelle CreditAttribution: malte.koelle at Unic commented
Status: Active » Needs review
FileSize
drupal-9-compability-3090734-2.patch314 bytes

I've added the version requirements to the info.yml file. The upgrade status module doesn't find any known issues anymore.

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi at Unic commented
Status: Needs review » Fixed

Thanks maltekoelle!

dermario’s picture

dermario
Primary language German
Location Zürich
CreditAttribution: dermario at Unic commented
Status: Fixed » Needs work

Sorry i need to reopen this issue. The 8.x-1.x branch is not compatible with Drupal 8 greater than 8.7.x Please see #3090596: Drupal 8.8.x compatibility for reference. 

+++ b/gin.info.yml
@@ -3,6 +3,7 @@ type: theme
+core_version_requirement: ^8 || ^9

As soon as gin 1.x is used with Claro in Drupal core, the site breaks due to outdated libraries overrides. So this line needs a fix.

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi at Unic commented
Status: Needs work » Fixed

Fixed to use
core_version_requirement: <8.8
for 8.x-1.x branch

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi at Unic commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.