When installing gin alpha2 on a 8.8.x site with claro installed i get the following errors:

The specified library "claro/drupal-theme" does not exist.
The specified library "claro/drupal.tableselect" does not exist.

This might be due to the fact, that claro was moved to drupal core and some library declarations changed.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dermario created an issue. See original summary.

dermario’s picture

Status: Active » Needs review
FileSize
468 bytes

I removed the failing libraries overrides to proceed. Maybe we should agree that we focus only on Claro in Drupal Core up from today.

dermario’s picture

Status: Needs review » Needs work

As discussed with @saschaeggi we should check/remove all the libraries-overrides. So i am putting this back to needs work.

dermario’s picture

Version: 8.x-1.x-dev » 8.x-2.x-dev

So this affects to 8.x-2.x which is supposed to work with the core implementation of claro.

dermario’s picture

Status: Needs work » Needs review
FileSize
3.83 KB

I updated the info.yml and removed all libraries extends and overrides, that are not required any more. (i hope)

dermario’s picture

FileSize
340 bytes
4.06 KB

Here's a patch with the right core_version_constraint.

saschaeggi’s picture

I've pushed this into 8.x-2.x-dev for now

dermario’s picture

FileSize
310 bytes
4.08 KB

I've found another bug that should be fixed now.

The 'core_version_requirement' constraint (^8.8) requires the 'core' key not be set in themes/gin/gin.info.yml

  • dermario committed 046be02 on 8.x-2.x
    Issue #3090596 by dermario, saschaeggi: Drupal 8.8.x compatibility
    
dermario’s picture

Status: Needs review » Fixed

  • dermario committed 04c40ad on 8.x-2.x
    Issue #3090596 by dermario, saschaeggi: Drupal 8.8.x compatibility
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.