Add a mechanism to transfer Docker images contained inside a K8s cloud server template over to ECR. Once transfered, update the container image url to the ECR version and copy it up to S3.

CommentFileSizeAuthor
#3 screenshot-20191029f.png845.39 KByas
#3 screenshot-20191029e.png867.58 KByas
#3 screenshot-20191029d.png665.96 KByas
#3 screenshot-20191029c.png173.61 KByas
#3 screenshot-20191029b.png797.06 KByas
#3 screenshot-20191029a.png737.41 KByas
#2 deployment.txt340 bytesbaldwinlouie
#2 3090650.patch57.21 KBbaldwinlouie
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

baldwinlouie created an issue. See original summary.

baldwinlouie’s picture

baldwinlouie CreditAttribution: baldwinlouie commented
Status: Active » Needs review
FileSize
3090650.patch57.21 KB
deployment.txt340 bytes

Added this functionality. The specifics are:

1. Added a Docker module that contains a service to talk with Docker. Note, Docker has to be installed on the same server as Cloud Orchestrator. There is a Docker admin/config/services/cloud/docker/settings page to specify the Docker socket.
2. Add an EcrService to talk with AWS ECR
3. Added code to cron to parse cloud server template yaml file, extract the container image urls, download the images, tag them for ECR, and finally push them up to ECR.
4. The steps in #3 can be fairly intensive. I ended up using batch to run through all the operations.
5. There is a new fieldset in K8sToS3AdminSettings so you can turn on this functionality and specify which AWS region to use for ECR
6. Slightly refactored the code in k8s_to_s3.module since this functionality shares the S3 copying code.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
FileSize
screenshot-20191029a.png737.41 KB
screenshot-20191029b.png797.06 KB
screenshot-20191029c.png173.61 KB
screenshot-20191029d.png665.96 KB
screenshot-20191029e.png867.58 KB
screenshot-20191029f.png845.39 KB

@baldwinlouie

Could you please review the patch?

@baldwinlouie

Thank you for adding the great feature. It looks good to me.

screenshot-20191029a.png
screenshot-20191029b.png
screenshot-20191029c.png
screenshot-20191029d.png
screenshot-20191029e.png
screenshot-20191029f.png

@xiaohua-guan

Could you please review the patch?

Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented

@all

Thanks for the great patch! The patch looks OK to me.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for your review. I'll merge the patch to 8.x-2.x and close this issue as Fixed.

  • yas committed 67b46ba on 8.x-2.x authored by baldwinlouie 
    Issue #3090650 by baldwinlouie, yas, Xiaohua Guan: Copy K8s template...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Related issues: +#3084313: Composer could not parse version constraint / could not load package

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.