I noticed that the menu--acount.html.twig, the menu (ul) not contain (li) for the menu items .

---
After the fix on a test of placement of the User account menu
After the fix on a test of placement of the User account menu

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

qusai taha created an issue. See original summary.

Qusai Taha’s picture

FileSize
1.42 KB
Rajab Natshah’s picture

FileSize
1.69 KB

Thank you Qusai for reporting and the patch
Good catch !!!

Better to follow the attributes way of adding classes

          {% set classes = [
            'nav-item',
            item.is_expanded ? 'menu-item--expanded',
            item.is_collapsed ? 'menu-item--collapsed',
            item.in_active_trail ? 'menu-item--active-trail',
          ] %}
          <li{{ item.attributes.addClass(classes) }}>

We will commit the fix in Vartheme BS4, But please report back with a patch to the Barrio project, as they do have the same issue in
https://git.drupalcode.org/project/bootstrap_barrio/blob/8.x-4.x/templat...

  • RajabNatshah committed cc48d5c on 8.x-6.x
    Issue #3091267 by qusai taha: Add li tags for menu item(ul) in menu--...
Rajab Natshah’s picture

Assigned: Qusai Taha » Mohammed J. Razem
Issue tags: +varbase-8.7.3
Rajab Natshah’s picture

Assigned: Mohammed J. Razem » Unassigned
Rajab Natshah’s picture

Status: Needs review » Fixed
Rajab Natshah’s picture

Issue summary: View changes
FileSize
348.23 KB
Rajab Natshah’s picture

Rajab Natshah’s picture

Title: Add li tags for menu item(ul) in menu--acount.html.twig » Add li tags for menu item(ul) in the menu acount template
Qusai Taha’s picture

Issue summary: View changes
Qusai Taha’s picture

Patch already exists in bootstrap_barrio .
Patch link : https://www.drupal.org/project/bootstrap_barrio/issues/3074369

Qusai Taha’s picture

Thanks, rajab.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.