The var settings.no_empty_message is used in autocomplete_deluxe.js but not defined in settings forms, so it's always 'undefined' and fired the default value.

this.no_empty_message = typeof settings.no_empty_message == 'undefined' ? 'No terms could be found. Please type in order to add a new term.' : settings.no_empty_message;
CommentFileSizeAuthor
#7 no-empty-message-with-t-3025375-6.patch3.31 KBoriol_e9g
#6 no-empty-message-without-t-3025375-6.patch3.3 KBoriol_e9g
#6 no-empty-message-with-t-3025375-6.patch3.31 KBoriol_e9g
#5 no-empty-message-settings-3025375-5.patch3.31 KBoriol_e9g
#3 no-empty-message-settings-3025375-2.patch3.3 KBoriol_e9g
#2 no-empty-message-settings-3025375.patch5.35 KBoriol_e9g
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

oriol_e9g created an issue. See original summary.

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g at Diputació de Barcelona commented
Status: Active » Needs review
FileSize
no-empty-message-settings-3025375.patch5.35 KB
oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g at Diputació de Barcelona commented
FileSize
no-empty-message-settings-3025375-2.patch3.3 KB

Oh! I'm touching code that's out of scope, minimizing changes.

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g at Diputació de Barcelona commented
Title: You can't set no_empty_message in widget settings » no_empty_message is missing in widget settings
oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g at Diputació de Barcelona commented
FileSize
no-empty-message-settings-3025375-5.patch3.31 KB

If you apply tthe solution in #3025308: Drupal.t cannot translate strings passed through vars we need to translate the string in php side. If you prefer other solution for message translations you can apply patch in #2.

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g at Diputació de Barcelona commented
FileSize
no-empty-message-with-t-3025375-6.patch3.31 KB
no-empty-message-without-t-3025375-6.patch3.3 KB

Fixing missing semicolon in previos patches. Attach two patches with t function and without t function.

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g at Diputació de Barcelona commented
FileSize
no-empty-message-with-t-3025375-6.patch3.31 KB

#3025308: Drupal.t cannot translate strings passed through vars is commited, reupload the correct patch.

edwardchiapet’s picture

edwardchiapet
Location New York, NY
CreditAttribution: edwardchiapet at Mediacurrent commented

Thank you, @oriol_e9g!

I have tested the patch and confirmed that it adds the empty message to the widget settings.

Will merge into 8.x-1.x-dev.

edwardchiapet’s picture

edwardchiapet
Location New York, NY
CreditAttribution: edwardchiapet at Mediacurrent commented
Assigned: oriol_e9g » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.