Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.When there is at least one person signed up for an event, the form is being called differently and brokenly by straight up creating the object without passing the parameters. This results in:
Too few arguments to function Drupal\simply_signups\Form\SimplySignupsForm::__construct(), 0 passed in /home/vagrant/docroot/web/modules/contrib/simply_signups/simply_signups.module on line 103
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | simplysignups_3079430-2_fix_missing_parameters.patch | 1.39 KB | Michelle |
Comments
Comment #2
MichelleThis patch changes the two places where it was instantiating the object directly to use the same code as the one that works, presumably because doing it that way fires the create() method.
Comment #3
anthonyf CreditAttribution: anthonyf at Mediacurrent commentedHi Michelle,
I reviewed your patch #2 and the code change looks solid.
I'll try to test the functionality locally next.
Comment #4
anthonyf CreditAttribution: anthonyf at Mediacurrent commentedHi Michelle,
In testing this patch I had to also apply another patch of yours first, from this issue: https://www.drupal.org/project/simply_signups/issues/3079427
In my testing the form wouldn't submit at all without the above patch applied^.
Comment #5
anthonyf CreditAttribution: anthonyf at Mediacurrent commentedTested patch #2 locally after one user had signed up, and it fixed the fatal error for me. Nice work!
Comment #6
anthonyf CreditAttribution: anthonyf at Mediacurrent commentedComment #7
irodriguez CreditAttribution: irodriguez commentedThank you again for the help and the patch. I am still new to contributing. Do I need to apply the patch on my end or does Drupal handle it via this UI?
Comment #8
MichelleHello irodriguez,
To apply, do this:
If you don't already have it set up locally, go to the version control tab here: https://www.drupal.org/project/simply_signups/git-instructions and make sure the maintainer box is checked and get the clone command. Then clone it locally.
Once you have that, apply the patch locally. There are instructions on that same page. I also find using this handy:
curl <link to patch> | patch -p1That downloads it right into patching so you aren't left with the patch file to delete.
If you want, you can test the patch at this point.
To commit it, scroll down to the bottom of the ticket. There is a section to mark contributors. Put a checkmark by anyone you think has helped on the ticket.
Then you can just copy the commit message out of the textbox and it will automatically credit the right people.
Then you do git push origin 8.x-2.x
That pushes the updated branch up to drupal.org. Because the ticket number is in the commit message, it will automatically comment on this ticket and also credit everyone in there.
Hope that helps!
Comment #9
Michelle@irodriguez,
Just checking in on this because I haven't seen any activity since I explained a couple weeks ago. If you don't have time for it, I've got an offer to co-maintain over here: https://www.drupal.org/project/simply_signups/issues/3081764
Comment #10
MichelleBumping this again. There is more that I'd like to do with this module and it would be nice to not have to build on a pile of patches.
Comment #11
irodriguez CreditAttribution: irodriguez commentedMichelle,
My schedule lately has been really hectic.
I will be setting aside a slot of time this weekend 11/02/2019 to really, dive back into this project.
If you are wanting to help in a more longterm fashion (like as a co-maintainer), please let me know how to, and I can add you to the project's git repo.
Thanks,
Ivan Rodriguez
Comment #12
MichelleYou can add maintainers here: https://www.drupal.org/node/3031034/maintainers . Because of my elevated permissions on d.o, I can add myself; it's just not ethical to do it without permission. Since you seem ok with it, I can go ahead and do that if you haven't by the time I have a chance to work on the module again so I can get those patches in. I won't make any major changes without running them by you. One of the things I want to do for my personal needs is a fairly large change so I won't commit that without your ok.
Comment #13
irodriguez CreditAttribution: irodriguez commentedMichelle,
I have added you as a maintainer (full rights). I really do appreciate the help with this project. I have a vision of this project becoming something reliable that people can use to manage the rsvps for their events, but I am not opposed to seeing this project expand beyond that scope. I just haven't had the time lately between my workload and personal stuff going on, to maintain this and do bug fixes as much as I want to.
Thanks,
Ivan
Comment #14
MichelleI totally get that. I've been really swamped, too, and haven't had much personal time to work on things. But I'm allowed to use some of my time at work to work on contrib projects so will spend some time on this in the later part of the week.
Comment #16
MichelleCommitted. :)