A temporary fix until #2991660: Views should respect the field formatter's isApplicable() method gets fixed.

CommentFileSizeAuthor
#8 commerce-3088905-calculated_field_views-8.patch1.49 KBczigor
#2 commerce-3088905-calculated_field_views-2.patch1.77 KBczigor
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

czigor created an issue. See original summary.

czigor’s picture

czigor CreditAttribution: czigor at Centarro commented
Status: Active » Needs review
FileSize
commerce-3088905-calculated_field_views-2.patch1.77 KB

  • bojanz committed 05befc0 on 8.x-2.x authored by czigor 
    Issue #3088905 by czigor: The "Calculated" price formatter must not show...
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Fixed

Tweaked and committed. Thanks!

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Fixed » Needs work

Reopening based on the report at #3091639: Calculated Price check breaking views fields. Looks like $field_definition is sometimes NULL.

bojanz credited Gode.Agarunov.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented

Crediting Gode.Agarunov for the bug report:

but for whatever reason it was being executed when I clicked views fields like "title" on the product entity to change settings like "link to product".

czigor’s picture

czigor CreditAttribution: czigor at Centarro commented
Status: Needs work » Needs review
FileSize
commerce-3088905-calculated_field_views-8.patch1.49 KB
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Fixed

Pushed a followup. For some reason $handler->options['entity_type'] isn't always set. This would cause problems as soon as field definitions were retrieved.

Reproduced the error on the product admin view, manually tested to ensure it now works (and that the original fix is still active where needed).

  • bojanz committed 885ec54 on 8.x-2.x 
    Issue #3088905 followup: Guard against an empty entity type ID.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.