System update 8702 fails with " Error: Call to a member function getKey() on null in core\modules\system\system.install" [#3052467]

After updating to Drupal 8.7.0 and updating the database using drush updb system update 8702 fails. I'm not sure how to debug this, or where that error message is coming from exactly

> [notice] Update started: system_update_8702
> [error] Call to a member function getKey() on null

Any one experienced the same problem and have any idea how to fix this?
Thanks.

Stack trace from a duplicate issue:

php error report
[03-May-2019 11:34:15 America/Halifax] Error: Call to a member function getKey() on null in H:\new-drupal-project\web\core\modules\system\system.install on line 2278 #0 H:\new-drupal-project\web\core\includes\update.inc(184): system_update_8702(Array)
#1 H:\new-drupal-project\web\core\includes\batch.inc(295): update_do_one('system', 8702, Array, Array)
#2 H:\new-drupal-project\web\core\includes\batch.inc(137): _batch_process()
#3 H:\new-drupal-project\web\core\includes\batch.inc(93): _batch_do()
#4 H:\new-drupal-project\web\core\modules\system\src\Controller\DbUpdateController.php(186): _batch_page(Object(Symfony\Component\HttpFoundation\Request))
#5 [internal function]: Drupal\system\Controller\DbUpdateController->handle('start', Object(Symfony\Component\HttpFoundation\Request))
#6 H:\new-drupal-project\web\core\lib\Drupal\Core\Update\UpdateKernel.php(115): call_user_func_array(Array, Array)
#7 H:\new-drupal-project\web\core\lib\Drupal\Core\Update\UpdateKernel.php(76): Drupal\Core\Update\UpdateKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request))
#8 H:\new-drupal-project\web\update.php(28): Drupal\Core\Update\UpdateKernel->handle(Object(Symfony\Component\HttpFoundation\Request))
#9 {main}

Comment	File	Size	Author
#26	3052467-failing.patch	1.01 KB	gease
#26
#12	3052467-12.patch	4.51 KB	amateescu
#12	8.7.x: PHP 7.1 & MySQL 5.7 26,311 pass
#12	3052467-12-test-only.patch	3.36 KB	amateescu
#12	8.7.x: PHP 7.1 & MySQL 5.7 26,306 pass, 2 fail
#6	3052467.patch	1.14 KB	amateescu
#6	8.7.x: PHP 7.1 & MySQL 5.7 26,306 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

3 May 2019 at 14:44

Rick Bergmann created an issue. See original summary.

Comment #2

Rick Bergmann CreditAttribution: Rick Bergmann as a volunteer and commented 3 May 2019 at 14:45

Issue summary:

View changes

Comment #3

cilefen CreditAttribution: cilefen as a volunteer commented 3 May 2019 at 14:57

Title:	System update 8702 fails for me	» System update 8702 fails with " Error: Call to a member function getKey() on null in core\modules\system\system.install"
Category:	Support request	» Bug report
Issue summary:	View changes
Priority:	Normal	» Major

Comment #4

xjm

she/her

English

CreditAttribution: xjm at Acquia commented 3 May 2019 at 17:09

Version:	8.7.0	» 8.7.x-dev
Priority:	Major	» Critical
Issue tags:		+8.7.0 update

Comment #5

Rick Bergmann CreditAttribution: Rick Bergmann as a volunteer and commented 3 May 2019 at 17:15

Issue summary:

View changes

File	Size
3052467.patch	1.14 KB
8.7.x: PHP 7.1 & MySQL 5.7 26,306 pass

Comment #7

Rick Bergmann CreditAttribution: Rick Bergmann as a volunteer and commented 3 May 2019 at 19:43

Yes, the patch works for me. Thank You @amateescu!

Comment #8

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented 3 May 2019 at 19:47

No problem, it's nice to see that's the only problem you had with the 8.7.0 update :)

Comment #9

Ulminia CreditAttribution: Ulminia commented 3 May 2019 at 21:06

patch applied and working now i have another issue

taxonomy module
Update make_taxonomy_term_revisionable
Failed: Drupal\Core\Entity\EntityStorageException: The entity update process failed while processing the entity type taxonomy_term, ID: 1. in Drupal\Core\Entity\Sql\SqlContentEntityStorageSchema->copyData() (line 216 of H:\\web\core\lib\Drupal\Core\Entity\Sql\SqlFieldableEntityTypeListenerTrait.php).
menu_link_content module
Update make_menu_link_content_revisionable
Custom menu links have been converted to be revisionable

ideas?

Comment #10

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented 3 May 2019 at 21:27

@Ulminia, can you check the recent log messages and see if there's any error recorded there?

Comment #11

plach

he/him

Italian

Venezia

CreditAttribution: plach for Acquia commented 5 May 2019 at 22:13

Status:	Needs review	» Needs work
Issue tags:		+Needs tests

#9 seems a separate problem, the patch looks good to me and fixes the issue reported in the OP. Setting to NW for the missing test coverage.

Comment #12

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented 6 May 2019 at 09:35

Status:	Needs work	» Needs review
Issue tags:	-Needs tests

File	Size
3052467-12-test-only.patch	3.36 KB
8.7.x: PHP 7.1 & MySQL 5.7 26,306 pass, 2 fail
3052467-12.patch	4.51 KB
8.7.x: PHP 7.1 & MySQL 5.7 26,311 pass

Here's the test coverage. The test-only file is also the interdiff.

Comment #13

6 May 2019 at 10:17

The last submitted patch, 12: 3052467-12-test-only.patch, failed testing. View results

Comment #14

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented 7 May 2019 at 11:23

Status:

Needs review

» Reviewed & tested by the community

Tests were added, I think this is ready for a committer review.

Comment #15

plach

he/him

Italian

Venezia

CreditAttribution: plach for Acquia commented 8 May 2019 at 22:26

RTBC +1

Comment #16

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott at Acro Commerce, Thunder commented 8 May 2019 at 22:30

Status:

Reviewed & tested by the community

» Fixed

Committed and pushed e14126d6a8 to 8.8.x and 2962eb2495 to 8.7.x. Thanks!

Nice find @Rick Bergmann and nice fix @amateescu. Thanks!

Comment #17

8 May 2019 at 22:30

alexpott committed e14126d on 8.8.x

Issue #3052467 by amateescu, Rick Bergmann: System update 8702 fails...

Comment #18

8 May 2019 at 22:30

alexpott committed 2962eb2 on 8.7.x

Issue #3052467 by amateescu, Rick Bergmann: System update 8702 fails...

Comment #19

gregrusson CreditAttribution: gregrusson commented 9 May 2019 at 15:54

I am having this same issue. Can someone guide me as to how I apply this patch to Druap 8.7.x?

Comment #20

cilefen CreditAttribution: cilefen as a volunteer commented 9 May 2019 at 15:56

https://www.drupal.org/patch/apply is the basic. If you manage the site with Composer, use https://github.com/cweagans/composer-patches.

Comment #21

gregrusson CreditAttribution: gregrusson commented 9 May 2019 at 16:50

Thanks, @cilefen, I was able to get it to work through composer.

Comment #22

MagdalenaA67 CreditAttribution: MagdalenaA67 commented 9 May 2019 at 19:11

Same error solved without patch.

I ran the update from 8.6.15 to 8.7.1 and first had the same errors:
[error] Call to a member function getKey() on null
[error] Update failed: system_update_8702

I then started over because the patch didn't work for me. I checked out live and dropped current db and added backup of live database to get me back to before I ran the update. I then ran these commands and it worked.

With new branch created from live and live update now local...

composer update drupal/core webflo/drupal-core-require-dev --with-dependencies
drush cr
drush updb
drush cr
check UI /admin/config/development/configuration if config isn't clean, which it should not be run drush cex

Comment #23

pameeela CreditAttribution: pameeela as a volunteer commented 16 May 2019 at 22:16

Thanks everyone for taking part in this issue. If you'd like to help us make sure the 8.8.0 update is as smooth as possible, please consider signing up for the beta testing program at https://goo.gl/forms/bMBTMRSY3sKEscUJ3

Comment #24

30 May 2019 at 22:19

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #25

gease

he/him

Russian

Praha

CreditAttribution: gease at bio.logis Genetic Information Management GmbH commented 5 November 2019 at 17:39

The testDeletedEntityType test, introduced with this patch, breaks other post-update hook tests, #2960643-23: Cannot load entity by uuid after rename for example. What we do there is iterating through all config entities and loading them by UUID. $loadable = (bool) $entity_repository->loadEntityByUuid($entity_type_id, $entity->uuid()); This should be perfectly valid operation in post-update hook, but field configuration loading throws PluginNotFoundException 'The entity_test_update entity type does not exist.'
Created a separate issue #3092497: Deleted entity types now break update tests about that.