See https://git.drupalcode.org/project/images_optimizer/blob/8.x-1.x/images_...

It will ease testing.

CommentFileSizeAuthor
#7 entity_visibility_preview-move_entity_visibility_preview_entity_access_into_class-3096799-7.patch7.93 KBPiegefull
#5 entity_visibility_preview-move_entity_visibility_preview_entity_access_into_class-3096799-5.patch6.97 KBPiegefull
#4 entity_visibility_preview-move_entity_visibility_preview_entity_access_into_class-3096799-4.patch6.76 KBPiegefull
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Grimreaper created an issue. See original summary.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented
Title: Move the code form entity_visibility_preview_entity_access into a class with proper dependency injection » Move the code from entity_visibility_preview_entity_access into a class with proper dependency injection

Fix typo in title.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented
Version: » 8.x-1.x-dev
Piegefull’s picture

Piegefull CreditAttribution: Piegefull at Smile commented
Assigned: Piegefull » Grimreaper
Status: Active » Needs review
FileSize
entity_visibility_preview-move_entity_visibility_preview_entity_access_into_class-3096799-4.patch6.76 KB
Piegefull’s picture

Piegefull CreditAttribution: Piegefull at Smile commented
FileSize
entity_visibility_preview-move_entity_visibility_preview_entity_access_into_class-3096799-5.patch6.97 KB

After rebase a code testing fix.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented
Assigned: Grimreaper » Piegefull
Status: Needs review » Needs work 
  1. +++ b/src/HookHandler/EntityAccessHookHandler.php
@@ -0,0 +1,79 @@
+   *   TRUE if the condition is satisfied, FALSE otherwise.

    Wrong comment. AccessResult depending on plugins evalutaion result. 

  2. +++ b/src/HookHandler/EntityAccessHookHandler.php
@@ -0,0 +1,79 @@
+    $entityVisibilityPreviewConditionPluginManager = \Drupal::service('plugin.manager.entity_visibility_preview_condition');

    The goal is to have dependency injection.

Piegefull’s picture

Piegefull CreditAttribution: Piegefull at Smile commented
Assigned: Piegefull » Grimreaper
Status: Needs work » Needs review
FileSize
entity_visibility_preview-move_entity_visibility_preview_entity_access_into_class-3096799-7.patch7.93 KB

1. Done
2. Done

  • Piegefull authored ce5a4a2 on 8.x-1.x 
    Issue #3096799 by Piegefull, Grimreaper: Move the code from...
Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented
Assigned: Grimreaper » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.