Problem/Motivation

\Drupal\Component\Utility\Unicode::caseFlip() is not used or tested in core. It is also not used in contrib http://grep.xnddx.ru/search?text=caseFlip&filename=

It was used internally by PHP5 versions of the multistring method which are no longer needed.

Proposed resolution

Deprecate the method with no replacement.

Remaining tasks

Create change record and deprecate the method.

User interface changes

None

API changes

Unicode::caseFlip() is deprecated

Data model changes

None

Release notes snippet

N/a

CommentFileSizeAuthor
#2 3057321-2.patch1.94 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Active » Needs review
FileSize
3057321-2.patch1.94 KB
John Cook’s picture

John Cook CreditAttribution: John Cook at Creode commented
Status: Needs review » Reviewed & tested by the community

The patch applies cleanly, adding the depreciation message to the docblock and setting an error message if the function is used when testing code.

The function is not used either in core or any contributed module that we can find.

Setting to RTBC.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 79f8c0a and pushed to 8.8.x. Thanks!

  • catch committed 79f8c0a on 8.8.x 
    Issue #3057321 by alexpott: Deprecate Unicode::caseFlip()

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Krzysztof Domański’s picture

Krzysztof Domański
Location Poland
CreditAttribution: Krzysztof Domański at abventor commented

Published CR.