Problem/Motivation

Tested the module for being D9 Ready at DrupalCon Seattle 2019 using http://www.github.com/mglaman/drupal-check. Found one issue.

Line src/Plugin/Field/FieldWidget/AggridWidgetType.php
------ ------------------------------------------------------------
53 Call to deprecated method entityManager() of class Drupal.

Proposed resolution

Change the code to use \Drupal::entityTypeManager()

CommentFileSizeAuthor
#6 Screen Shot 2019-04-15 at 11.13.38 PM.png701.81 KBsean_e_dietrich
#6 Screen Shot 2019-04-15 at 11.12.45 PM.png783.36 KBsean_e_dietrich
#6 Screen Shot 2019-04-15 at 11.13.49 PM.png11.55 KBsean_e_dietrich
#6 Screen Shot 2019-04-15 at 11.13.20 PM.png22.43 KBsean_e_dietrich
#4 3046971-4.patch646 bytesmferanda
#2 3046971-2.patch658 bytesmferanda
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mferanda created an issue. See original summary.

mferanda’s picture

mferanda CreditAttribution: mferanda as a volunteer commented
FileSize
3046971-2.patch658 bytes
mferanda’s picture

mferanda CreditAttribution: mferanda as a volunteer commented
Status: Active » Needs review
mferanda’s picture

mferanda CreditAttribution: mferanda as a volunteer commented
FileSize
3046971-4.patch646 bytes
mferanda’s picture

mferanda CreditAttribution: mferanda as a volunteer commented
Issue summary: View changes
sean_e_dietrich’s picture

sean_e_dietrich
he/him
Primary language English
Location Sacramento, CA
CreditAttribution: sean_e_dietrich at Kanopi Studios commented
Status: Needs review » Reviewed & tested by the community
FileSize
Screen Shot 2019-04-15 at 11.13.20 PM.png22.43 KB
Screen Shot 2019-04-15 at 11.13.49 PM.png11.55 KB
Screen Shot 2019-04-15 at 11.12.45 PM.png783.36 KB
Screen Shot 2019-04-15 at 11.13.38 PM.png701.81 KB

Patch applies successfully. Provided screenshots of before and after patch applied to code and also provided before and after screenshots of running drupal-check. Marking RTBC.

  • mferanda committed 2dfa936 on 8.x-1.x 
    Issue #3046971 by mferanda: Drupal 9 Ready
  • mferanda committed 5ed3cf0 on 8.x-1.x
    Issue #3046971 by mferanda, sean_e_dietrich: Drupal 9 Ready
mferanda’s picture

mferanda CreditAttribution: mferanda as a volunteer commented
Status: Reviewed & tested by the community » Patch (to be ported)
mferanda’s picture

mferanda CreditAttribution: mferanda as a volunteer commented
Status: Patch (to be ported) » Fixed
mferanda’s picture

mferanda CreditAttribution: mferanda as a volunteer commented
Status: Fixed » Closed (fixed)
Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented
Issue tags: -Drupal 9

Per a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.