See https://www.drupal.org/node/2774931

CommentFileSizeAuthor
#13 interdiff-3000116-11-13.txt422 bytesscott_euser
#13 remove_usagedrupal_set_message-3000116-13.patch4.2 KBscott_euser
#12 remove_usagedrupal_set_message-3000116-11.patch3.98 KBharsh.behl
#10 remove_usagedrupal_set_message-3000116-10.patch3.85 KBharsh.behl
#6 remove_usagedrupal_set_message-3000116-5.patch8.74 KBharsh.behl
#4 remove_usagedrupal_set_message-3000116-4.patch8.67 KBharsh.behl
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

larowlan created an issue. See original summary.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext for Charles Darwin University commented

See https://www.drupal.org/node/2774931

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext for Charles Darwin University commented
Issue summary: View changes
harsh.behl’s picture

harsh.behl CreditAttribution: harsh.behl commented
Status: Active » Needs review
FileSize
remove_usagedrupal_set_message-3000116-4.patch8.67 KB

Hi @larowlan,

Please find the patch for the same.

Thanks
Pen

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext for Charles Darwin University commented
Issue tags: +Release blocker

Thanks!

harsh.behl’s picture

harsh.behl CreditAttribution: harsh.behl commented
FileSize
remove_usagedrupal_set_message-3000116-5.patch8.74 KB

The last submitted patch, 4: remove_usagedrupal_set_message-3000116-4.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 6: remove_usagedrupal_set_message-3000116-5.patch, failed testing. View results

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext for Charles Darwin University commented
Status: Needs work » Needs review

I can't get the patch to apply locally either, it looks scrambled - can you check your text encoding?

harsh.behl’s picture

harsh.behl CreditAttribution: harsh.behl commented
FileSize
remove_usagedrupal_set_message-3000116-10.patch3.85 KB

New Patch

Status: Needs review » Needs work

The last submitted patch, 10: remove_usagedrupal_set_message-3000116-10.patch, failed testing. View results

harsh.behl’s picture

harsh.behl CreditAttribution: harsh.behl commented
FileSize
remove_usagedrupal_set_message-3000116-11.patch3.98 KB
scott_euser’s picture

scott_euser CreditAttribution: scott_euser as a volunteer and at Soapbox Communications Ltd commented
Status: Needs work » Needs review
FileSize
remove_usagedrupal_set_message-3000116-13.patch4.2 KB
interdiff-3000116-11-13.txt422 bytes

Updated patch to fix test BUT this will still fail as there are other deprecations. I believe the other deprecations should be dealt with in separate issues.

scott_euser’s picture

scott_euser CreditAttribution: scott_euser as a volunteer and at Soapbox Communications Ltd commented
Issue tags: +ContributionWeekend2019

  • larowlan committed 7046395 on 8.x-1.x authored by scott_euser 
    Issue #3000116 by pen, scott_euser, larowlan: [9.x] Remove usage of...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext for Charles Darwin University commented
Status: Needs review » Fixed

I believe the other deprecations should be dealt with in separate issues.

Agree, scope++

Thanks! - Committed and pushed to 8.x-1.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented
Issue tags: -Drupal 9, -Release blocker +Drupal 9 compatibility

Per a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.