Automated testing fails and returns a deprecation notice after running "Drupal\Tests\multiselect\FunctionalJavascript\MultiselectElementJavascriptTest ". Deprecation notice returns "Drupal\FunctionalJavascriptTests\JavascriptTestBase is deprecated in Drupal 8.5.x and will be removed before Drupal 9.0.0. Instead, use Drupal\FunctionalJavascriptTests\WebDriverTestBase." See attached screenshot.

It seems like we should change "JavascriptTestBase" to "WebDriverTestBase" as it suggests in the notice.

Steps to test:

1) Navigate to 'admin/config/development/testing'
2) Select "Multiselect" check box
3) Scroll down to bottom of list and click "Run tests"

Patch to follow.

CommentFileSizeAuthor
#2 testing-error-2992045-2.patch781 bytesdani3lr0se
multiselect-testing-error.png265.76 KBdani3lr0se
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

daniel_rose created an issue. See original summary.

dani3lr0se’s picture

dani3lr0se CreditAttribution: dani3lr0se at Hook 42 commented
Assigned: dani3lr0se » Unassigned
Status: Active » Needs review
FileSize
testing-error-2992045-2.patch781 bytes

Here is a patch for review. Changing "JavascriptTestBase" to "WebDriverTestBase" makes the test pass. Seems like the problem is solved after changing the name.

dani3lr0se’s picture

dani3lr0se CreditAttribution: dani3lr0se at Hook 42 commented
Issue summary: View changes
volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
CreditAttribution: volkswagenchick at Hook 42 commented

The patch applied using simplytest.me.

When I " Navigate to 'admin/config/development/testing' " - I am taken to a page not found...are there more steps to reproduce?

dani3lr0se’s picture

dani3lr0se CreditAttribution: dani3lr0se at Hook 42 commented

@volkswagenchick, I know we've chatted already, I just wanted to make a note here. We just need to enable the testing module in core. Thanks for reviewing. :)

Status: Needs review » Needs work

The last submitted patch, 2: testing-error-2992045-2.patch, failed testing. View results

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and at Hook 42 commented
Status: Needs work » Patch (to be ported)

This may seem odd but the testbot doesnt seem to be using the new patch, which should fix the testing error.

I'm going to merge this in and, hopefully, it addresses the issue. We'll patch forward with any issues.

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and at Hook 42 commented
Status: Patch (to be ported) » Fixed

Patch merged, we'll move forward with anything else needed. Closing for now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented
Issue tags: +Drupal 9 compatibility

Per a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.