Before:
------ --------------------------------------------------------------------------------------------------------------------------------------------
Line stream_wrapper_example/src/StreamWrapper/SessionStreamWrapper.php
------ --------------------------------------------------------------------------------------------------------------------------------------------
80 Usage of deprecated trait Drupal\Core\Routing\UrlGeneratorTrait in class Drupal\stream_wrapper_example\StreamWrapper\SessionStreamWrapper:
in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
Use \Drupal\Core\Url instead.
159 \Drupal calls should be avoided in classes, use dependency injection instead
203 Call to deprecated method url() of class Drupal\stream_wrapper_example\StreamWrapper\SessionStreamWrapper:
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Url::fromUri() instead.
------ --------------------------------------------------------------------------------------------------------------------------------------------

CommentFileSizeAuthor
#6 interdiff.txt1.47 KBandypost
#6 3072433-6.patch1.85 KBandypost
#5 interdiff.txt1.31 KBandypost
#5 3072433-5.patch2.39 KBandypost
#4 3072433_3.patch2.32 KBvrs11
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vrs11 created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Related issues: +#3048126: Make it easier to inject the FileSystem service

There's no way to inject container into stream wrappers yet, so just add @todo pointing to #3048126: Make it easier to inject the FileSystem service

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs review » Active
vrs11’s picture

vrs11 CreditAttribution: vrs11 as a volunteer commented
Status: Active » Needs review
FileSize
3072433_3.patch2.32 KB
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
FileSize
3072433-5.patch2.39 KB
interdiff.txt1.31 KB 
+++ b/stream_wrapper_example/src/StreamWrapper/SessionStreamWrapper.php
@@ -156,7 +160,7 @@ class SessionStreamWrapper implements StreamWrapperInterface {
-    $this->sessionHelper = \Drupal::service('stream_wrapper_example.session_helper');
+    $this->sessionHelper = $this->getSessionHelper();

this a bit out of scope of deprecated code clean-up but I went ahead and fixed it

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
FileSize
3072433-6.patch1.85 KB
interdiff.txt1.47 KB

Still better not introduce new method's as fate unclear

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs review » Reviewed & tested by the community

that's should be enough

  • valthebald committed 83552e6 on 8.x-1.x 
    Issue #3072433 by andypost, vrs11: fix drupal check on report on...
valthebald’s picture

valthebald
Location Sofia
CreditAttribution: valthebald at Dropsolid commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x-1.x, thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented
Issue tags: +Drupal 9 compatibility

Per a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.