Problem/Motivation

Currently this module saves 6 records in config. add_disable_roles and add_enable_roles can be merged to 1 item. The same for edit_disable_roles and edit_enable_roles. Also when the config is saved and no roles are selected, this item can be removed from the config file.

Remaining tasks

  • Remove unused config items
  • Edit tests
  • Add an upgrade path.
CommentFileSizeAuthor
#5 3097692-4.patch26.3 KBJeroenT
#4 interdiff-3097692-2-3.txt1.43 KBJeroenT
#4 3097692-3.patch21.3 KBJeroenT
#2 3097692-2.patch20.78 KBJeroenT
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JeroenT created an issue. See original summary.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
FileSize
3097692-2.patch20.78 KB
JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Status: Active » Needs review
JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
FileSize
3097692-3.patch21.3 KB
interdiff-3097692-2-3.txt1.43 KB
JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
FileSize
3097692-4.patch26.3 KB

  • JeroenT committed ebcb7b1 on 8.x-2.x 
    Issue #3097692 by JeroenT: Simplify saved config
JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented

Committed and pushed to 8.x-2.x.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.