drupal-check against views_negate 8.x-1.x-dev (30 Nov 2019)

➜  d9readiness vendor/mglaman/drupal-check/drupal-check web/modules/contrib/views_negate
 3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ --------------------------------------------------------------------------
  Line   views_negate.views.inc
 ------ --------------------------------------------------------------------------
  12     Call to deprecated method entityManager() of class Drupal:
         in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
         Use \Drupal::entityTypeManager() instead in most cases. If the needed
         method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see the
         deprecated \Drupal\Core\Entity\EntityManager to find the
         correct interface or service.
 ------ --------------------------------------------------------------------------


 [ERROR] Found 1 error

Upgrade status report warning against views_negate 8.x-1.x-dev (30 Nov 2019)

Add core_version_requirement: ^8 || ^9 to views_negate.info.yml to designate that the module is compatible with Drupal 9. See https://www.drupal.org/node/3070687.

CommentFileSizeAuthor
#4 drupal_9_deprecated_code_report-3097790-3.patch1.16 KBGnanagowthaman sankar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yogeshmpawar created an issue. See original summary.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar at QED42 commented
Issue tags: +Drupal 9 compatibility
Gnanagowthaman sankar’s picture

Gnanagowthaman sankar CreditAttribution: Gnanagowthaman sankar as a volunteer and at UniMity Solutions Pvt Limited commented

Hi @yogeshmpawar

Here by attached the patch. Please let me know for the changes.

Thanks & Regards,
Gnanagowthaman sankar

Gnanagowthaman sankar’s picture

Gnanagowthaman sankar CreditAttribution: Gnanagowthaman sankar as a volunteer and at UniMity Solutions Pvt Limited commented
Status: Active » Needs review
FileSize
drupal_9_deprecated_code_report-3097790-3.patch1.16 KB

Patch

Thanks & Regards,
Gnanagowthaman sankar

  • yogeshmpawar committed fb996bc on 8.x-1.x 
    Issue #3097790 by Gnanagowthaman sankar, yogeshmpawar: Drupal 9...
yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar at QED42 commented
Status: Needs review » Fixed

Committed & Pushed to 8.x-1.x branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.