Problem/Motivation

simplesamlphp_auth.settings contains a key default_langcode that contains the 'Site default language code' according to the simplesamlphp_auth.schema.yml

This configuration value is never used.

Proposed resolution

Remove 'Site default language code' from simplesamlphp_auth.settings

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#5 3097389-5.patch1.41 KBidebr
#5 interdiff-3-5.txt544 bytesidebr
#3 remove_site_default_language_code-3097389-2.patch903 bytesGnanagowthaman sankar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

idebr created an issue. See original summary.

Gnanagowthaman sankar’s picture

Gnanagowthaman sankar CreditAttribution: Gnanagowthaman sankar as a volunteer and at UniMity Solutions Pvt Limited commented

Hi @idebr

Here by I attached the patch. Please let me know for any changes in the patch.

Thanks & Regards,
Gnanagowthaman sankar

Gnanagowthaman sankar’s picture

Gnanagowthaman sankar CreditAttribution: Gnanagowthaman sankar as a volunteer and at UniMity Solutions Pvt Limited commented
Status: Active » Needs review
FileSize
remove_site_default_language_code-3097389-2.patch903 bytes
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Needs work

Yes, that makes sense, looks like it was copied from system.settings maybe?

Removing the config schema would make existing configs of sites invalid, so we should have an update function that removes that.

idebr’s picture

idebr CreditAttribution: idebr at iO commented
Status: Needs work » Needs review
FileSize
interdiff-3-5.txt544 bytes
3097389-5.patch1.41 KB

#4 Indeed it seems likely the config files were initially based on the system.settings file. Attached patch adds an update function to clear the default_langcode from existing configurations.

  • Berdir committed c5df806 on 8.x-3.x authored by idebr 
    Issue #3097389 by idebr, Gnanagowthaman sankar: Remove 'Site default...
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Fixed

Thanks, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.