Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#10 | 3098289-10.patch | 136.51 KB | Xiaohua Guan |
Comment | File | Size | Author |
---|---|---|---|
#10 | 3098289-10.patch | 136.51 KB | Xiaohua Guan |
Comments
Comment #2
Xiaohua Guan CreditAttribution: Xiaohua Guan commentedComment #3
Xiaohua Guan CreditAttribution: Xiaohua Guan commented@yas
Although I am still implementing the feature, could you test pages finished?
The following things are what I have done.
Comment #4
yas@xiaohua-guan
Thank you for adding the superb and exiting feature.
It looks good to me. I have a couple of comments:
a Plugin
as more OOP way? I think this is fine to keep the implementation at this point, though (refactor later).Budget
menu can be underDesign | <Cloud Service Provider>
menu (as the same level asServer Templates
)? ... because we literally design the Cloud Budgets. On the other hand,Cloud Credit
(current status) can be placed under each<Cloud Service Provider>
menu (as the same level asInstances
,Pods
, and etc)? It is fine to proceed to keep the current implementation, though (refactor later).Amount
ofCloud Credit
in some Cloud Budget admin settings.What do you think?
Comment #5
yasComment #6
Xiaohua Guan CreditAttribution: Xiaohua Guan commentedComment #7
Xiaohua Guan CreditAttribution: Xiaohua Guan commentedComment #8
Xiaohua Guan CreditAttribution: Xiaohua Guan commented@yas
> It would be nice to have if we can customize (setup) the initial Amount of Cloud Credit in some Cloud Budget admin settings.
I add initial amount of cloud credit to admin settings.
And I also added test cases for cloud credit entity.
Please review the patch file. Thanks.
Comment #9
Xiaohua Guan CreditAttribution: Xiaohua Guan commentedComment #10
Xiaohua Guan CreditAttribution: Xiaohua Guan commentedComment #11
Xiaohua Guan CreditAttribution: Xiaohua Guan commented@yas
I refactored some test codes. Could you review the patch file. Thanks.
Comment #12
yas@xiaohua-guan
Looks good, thanks!
Comment #13
yas@xiaohua-guan
Now the patch looks good to me.. I'll merge the patch to
8.x-2.x
and close this issue asFixed
.Comment #15
yasComment #16
yas