CommentFileSizeAuthor
#2 3099202-2.patch13.43 KBXiaohua Guan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
FileSize
3099202-2.patch13.43 KB
Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
Status: Active » Needs review
Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented

@yas

Please review the patch file. Thanks.

BTW, I added K8sExportableEntityInterface to refactor relative codes. Please confirm them.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community
Related issues: +#3095569: Composer could not parse version constraint / could not load package (2)

@xiaohua-guan

Thank you for adding the feature. I like your refactoring about K8sExportableEntityInterface. I tested it and looks good to me. I'll merge the patch to 8.x-2.x and close this issue as Fixed.

  • yas committed 0b73250 on 8.x-2.x authored by Xiaohua Guan 
    Issue #3099202 by Xiaohua Guan, yas: Export/import K8s Jobs
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.