Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Per the Module documentation guidelines, a module should Provide help text in the Drupal UI. This module is missing an implementation of hook_help().
Documentation:
https://www.drupal.org/docs/develop/documenting-your-project/module-docu...
https://www.drupal.org/node/632280
Patch to follow, thanks!
Comment | File | Size | Author |
---|---|---|---|
#6 | interdiff-3069498-4-6.txt | 929 bytes | JeroenT |
#6 | 3069498-6.patch | 1.48 KB | JeroenT |
| |||
#4 | interdiff-3069498-2-4.txt | 1.95 KB | JeroenT |
#4 | 3069498-4.patch | 1.49 KB | JeroenT |
| |||
#2 | webform_translation_permissions-hook_help-3069498-2.patch | 1.37 KB | alonaoneill |
Comments
Comment #2
alonaoneill CreditAttribution: alonaoneill at Hook 42 commentedComment #3
stefanos.petrakis@gmail.comThanks for this, here is a first review:
Needs an newline between the opening php tag and the use statement.
Needs an newline between previous function and upcoming doc comment
webform's instead of webforms
Unnecessary extra newline
Wrong indentation for the inline comment.
Missing whitespace between the , and the [ characters.
Wrong indentation for the closing brackets and parenthesis.
Well, nothing really serious here to correct. :-)
Cheers
Comment #4
JeroenTFixed the suggestions made in #3 and since we are updating the .module file, I added a file comment and a comment that we're implementing `hook_config_translation_info_alter`.
Comment #5
stefanos.petrakis@gmail.comThanks for the update.
The basic test coverage that was added thanks to your work on #3098717: Provide basic test coverage allowed testing the patch,
the bot reported the following coding standard messages:
webform_translation_permissions.module
I would also prefer if the
break
statement was removed, that would make the code a tiny bit neater.Also, I would expect to find the help hook implementation function as the first function in the file (cannot explain that further, it's really subjective).
Otherwise, tests are green. :-)
Comment #6
JeroenTFixed the coding standards, removed the break statemend and moved hook_help to the top of the module file.
Comment #7
JeroenTComment #8
stefanos.petrakis@gmail.comPerfect, thanks a bunch. Going to commit this in a couple of minutes.
Comment #10
stefanos.petrakis@gmail.comCommited and fixed. Thanks again to the both of you!
FYI: I intend to make a proper release out of the current dev branch, since it's minimally in a production-ready state (thanks to the tests).
Comment #11
stefanos.petrakis@gmail.com@JeroenT: Missed #3099279: Roadmap for stable release, agree completely with the roadmap.