Since #3098717: Provide basic test coverage was committed, we're also receiving reports about coding standards.

There are still a couple of CS errors that could be fixed.

CommentFileSizeAuthor
#4 3099281-4.patch7.23 KBstefanos.petrakis@gmail.com
#3 3099281-3.patch7.76 KBstefanos.petrakis@gmail.com
#2 3099281-2.patch7.67 KBJeroenT
#2 interdiff-3099281-1-2.txt786 bytesJeroenT
fix_coding_standards.patch6.7 KBJeroenT
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JeroenT created an issue. See original summary.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Title: Fix coding standars » Fix coding standards
FileSize
interdiff-3099281-1-2.txt786 bytes
3099281-2.patch7.67 KB

This should fix all the remaining errors.

stefanos.petrakis@gmail.com’s picture

stefanos.petrakis@gmail.com
Primary language English
Location Biel, Switzerland
CreditAttribution: stefanos.petrakis@gmail.com as a volunteer commented
FileSize
3099281-3.patch7.76 KB

Rerolling patch since it failed to apply.

stefanos.petrakis@gmail.com’s picture

stefanos.petrakis@gmail.com
Primary language English
Location Biel, Switzerland
CreditAttribution: stefanos.petrakis@gmail.com as a volunteer commented
FileSize
3099281-4.patch7.23 KB

Fixing the last pending coding standard issue (missing newline at end of file).

stefanos.petrakis@gmail.com’s picture

stefanos.petrakis@gmail.com
Primary language English
Location Biel, Switzerland
CreditAttribution: stefanos.petrakis@gmail.com as a volunteer commented
Status: Needs review » Reviewed & tested by the community

We are done here I believe.

stefanos.petrakis@gmail.com’s picture

stefanos.petrakis@gmail.com
Primary language English
Location Biel, Switzerland
CreditAttribution: stefanos.petrakis@gmail.com as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.