Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
With curl 7.66.0 instaclick/php-webdriver fail when testing with selenium/standalone-chrome with WebDriver\Exception\CurlExec: Webdriver http error: 400, payload :<h1>Bad Message 400</h1><pre>reason: Bad Content-Length</pre>
Proposed resolution
This is resolved in this commit from instaclick, but we subclass their service, so we need to update our class to match
Remaining tasks
None.
User interface changes
None.
API changes
None.
Data model changes
None.
Release notes snippet
None.
Comment | File | Size | Author |
---|---|---|---|
#2 | 3083183.patch | 1017 bytes | larowlan |
Comments
Comment #2
larowlanComment #3
jibranhttps://www.drupal.org/pift-ci-job/1414084 is passing so we do need a failing patch here.
Comment #4
acbramley CreditAttribution: acbramley at PreviousNext commentedMy guess would be that the 7.1 containers aren't using the new cURL. Definitely need the fix to run WebDriver tests on the latest version.
Comment #5
Wim LeersThanks to @acbramley for pointing out I filed a duplicate issue at #3084651: WebDriver HTTP error 400 Bad Content-Length errors. I wrote the exact same patch and a similar but slightly more detailed issue summary:
Comment #6
Wim LeersI bumped this to
because while it does not break DrupalCI today, it will whenever it is updated. It already breaks local development environments of core developers.Comment #7
Wim LeersComment #8
acbramley CreditAttribution: acbramley at PreviousNext commentedI've updated the blog post to make it more clear that core needs a different fix, I did have it in there but it wasn't as obvious :)
Comment #9
alexpottCommitted and pushed 56895fda5c to 8.8.x and 23240dd132 to 8.7.x. Thanks!
Backported to 8.7.x since this is a test fix.
I added the comment from the upstream commit because that seems useful.
Comment #12
Wim Leers@acbramley++ — I definitely missed that 😅
Comment #14
larowlanthis was backported to 8.7.x