Unable to update to 8.7.4: failed to apply patch for social_auth_google [#3102500]

When I run "composer update" to update to Varbase 8.7.4 I am getting the fatal error:

Installing drupal/social_auth_google (2.0.0): Downloading (100%)
- Applying patches for drupal/social_auth_google
https://www.drupal.org/files/issues/2019-02-20/3034353-2.patch (Issue #3034353: Change the Google+ logo to Google accounts as Google shutdown Google+)
Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2019-02-20/3034353-2.patch

[Exception]
Cannot apply patch Issue #3034353: Change the Google+ logo to Google accounts as Google shutdown Google+ (https://www.drupal.org/f
iles/issues/2019-02-20/3034353-2.patch)!

This stops the update process. As a result, I cannot update to Drupal 8.7.11 and apply other necessary security patches. I don't need social_auth_google and any other social_auth on my site. varbase_auth modulse should be optional (not every site needs social links) and varbase distro should not have it mandatory.

Comments

Comment #1

20 December 2019 at 21:26

calmforce created an issue. See original summary.

Comment #2

Joachim Namyslo

German

Kulmbach 🇩🇪 🇪🇺

CreditAttribution: Joachim Namyslo commented 22 December 2019 at 14:16

It's right some patches currently fail, but this shouldn't break the whole Update Process.

Here are currently failing patches

This file was automatically generated by Varbase Updater (https://github.com/Vardot/varbase-updater)
Patches failed to apply:

Patch: https://www.drupal.org/files/issues/2019-02-20/3034353-2.patch
Reason: Failed to apply patch
Description: Issue #3034353: Change the Google+ logo to Google accounts as Google shutdown Google+
Package Name: drupal/social_auth_google
Package Path: docroot/modules/contrib/social_auth_google

Patch: https://www.drupal.org/files/issues/2019-02-20/3034353-2.patch
Reason: Failed to apply patch
Description: Issue #3034353: Change the Google+ logo to Google accounts as Google shutdown Google+
Package Name: drupal/social_auth_google
Package Path: docroot/modules/contrib/social_auth_google

Patch: https://www.drupal.org/files/issues/2019-02-20/3034353-2.patch
Reason: Failed to apply patch
Description: Issue #3034353: Change the Google+ logo to Google accounts as Google shutdown Google+
Package Name: drupal/social_auth_google
Package Path: docroot/modules/contrib/social_auth_google

The Google + patch is among them but Varbase is running perfect, still

Comment #3

Joachim Namyslo

German

Kulmbach 🇩🇪 🇪🇺

CreditAttribution: Joachim Namyslo commented 22 December 2019 at 14:18

If you like to resolve this

1. recover from backup created by varbase updater
2. uninstall the social auth suite.
3. clear cache
4. re run updater
5. Tell me if you are lucky

Comment #4

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commented 22 December 2019 at 14:21

Released varbase_auth 8.x-6.7
https://www.drupal.org/project/varbase_auth/releases/8.x-6.7
#3102415: Remove the 3034353-2.patch for [Social Auth Google] as it was committed in 8.x-2.0 stable

Released varbase_core 8.x-7.8
https://www.drupal.org/project/varbase_core/releases/8.x-7.8
#3102559: Add the 3102555-3.patch for [Better Login] module to fix the remove all blocks in content region

Comment #5

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commented 22 December 2019 at 14:43

Thank you Vladimir for reporting and Joachim for following up
In my opinion, it's better to update the composer.lock
composer build and release a new tag

After we had released
vardot/varbase-updater 1.1.12
https://github.com/Vardot/varbase-updater/releases/tag/1.1.12
which was reported and fixed by Joachim Namyslo